fourth order OMF integrator added with input key OMF4 #170

Merged
merged 5 commits into from Apr 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

urbach commented Oct 12, 2012

this is an implementation of the parameter free fourth order OMF integrator from Omelyan, Mryglod, Folk, Comp.Phys.Commun 151 (2003) 272, equations (63) and (71).

@deuzeman deuzeman commented on an outdated diff Dec 24, 2012

@@ -34,12 +34,21 @@
integrator Integrator;
+const double rho = 0.2539785108410595;
+const double theta = -0.03230286765269967;
+const double vartheta = 0.08398315262876693;
+const double lamb = 0.6822365335719091;
@deuzeman

deuzeman Dec 24, 2012

Contributor

Not too enthusiastic about having parameters dumped into the global namespace, especially with generic names like 'rho' and 'theta'. Can't they be localized withing integrate_omf4? Or, barring that, at least be declared static?

Contributor

deuzeman commented Apr 9, 2013

Code looks clean now, compiles and runs fine.

@deuzeman deuzeman added a commit that referenced this pull request Apr 9, 2013

@deuzeman deuzeman Merge pull request #170 from urbach/omf4
fourth order OMF integrator added with input key OMF4
c9c0fb4

@deuzeman deuzeman merged commit c9c0fb4 into etmc:master Apr 9, 2013

urbach deleted the urbach:omf4 branch Nov 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment