Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

minor fixes to the demo and addition of a gitignore #9

Merged
merged 2 commits into from May 10, 2012

Conversation

Projects
None yet
2 participants
Contributor

ericbmerritt commented May 6, 2012

No description provided.

@richcarl richcarl and 1 other commented on an outdated diff May 7, 2012

.gitignore
@@ -0,0 +1,2 @@
+_build
+*.beam
@richcarl

richcarl May 7, 2012

Collaborator

why a *.beam at the top level? it's already in bin/.gitignore

@ericbmerritt

ericbmerritt May 7, 2012

Contributor

Richard,

That may just be habit on my part. *.beam in the top level makes it
ignore beams everywhere. I can fix that and resubmit the pull request
if you like.

Eric

On Mon, May 7, 2012 at 2:04 AM, Richard Carlsson
reply@reply.github.com
wrote:

@@ -0,0 +1,2 @@
+_build
+*.beam

why a *.beam at the top level? it's already in bin/.gitignore


Reply to this email directly or view it on GitHub:
https://github.com/etnt/gettext/pull/9/files#r779922

@richcarl

richcarl May 7, 2012

Collaborator

Yeah, I prefer to put .gitignores in the respective subdirectories as needed.

@ericbmerritt

ericbmerritt May 7, 2012

Contributor

No worries. I will update the pull request.

On Mon, May 7, 2012 at 1:43 PM, Richard Carlsson
reply@reply.github.com
wrote:

@@ -0,0 +1,2 @@
+_build
+*.beam

Yeah, I prefer to put .gitignores in the respective subdirectories as needed.


Reply to this email directly or view it on GitHub:
https://github.com/etnt/gettext/pull/9/files#r783163

@ericbmerritt

ericbmerritt May 9, 2012

Contributor

this should be resolved now in this request.

@richcarl richcarl added a commit that referenced this pull request May 10, 2012

@richcarl richcarl Merge pull request #9 from ericbmerritt/master
minor fixes to the demo and addition of a gitignore
80c4049

@richcarl richcarl merged commit 80c4049 into etnt:master May 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment