New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish for Scala 2.13.0-M5? #709

Closed
SethTisue opened this Issue Sep 27, 2018 · 21 comments

Comments

Projects
None yet
4 participants
@SethTisue
Copy link
Contributor

SethTisue commented Sep 27, 2018

prereqs:

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Sep 27, 2018

fwiw, after publishing kind-projector and scalacheck locally, in specs2 I see:

[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/MatcherZipOperators.scala:4:8: encountered unrecoverable cycle resolving import.
[specs2] [error] Note: this is often due in part to a class depending on a definition nested within its companion.
[specs2] [error] If applicable, you may wish to try moving some members into another object.
[specs2] [error] import MatchersImplicits._
[specs2] [error]        ^
[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/NumericMatchers.scala:160:24: illegal cyclic reference involving trait NumericMatchers
[specs2] [error] object NumericMatchers extends NumericMatchers {
[specs2] [error]                        ^
[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/StringMatchers.scala:171:46: java.util.regex.MatchResult does not take type parameters
[specs2] [error]   implicit def toStringResultMatcher(result: MatchResult[String]) = new StringResultMatcher(result)
[specs2] [error]                                              ^
[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/StringMatchers.scala:172:37: java.util.regex.MatchResult does not take type parameters
[specs2] [error]   class StringResultMatcher(result: MatchResult[String]) {
[specs2] [error]                                     ^
[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/MatcherZipOperators.scala:4:8: encountered unrecoverable cycle resolving import.
[specs2] [error] Note: this is often due in part to a class depending on a definition nested within its companion.
[specs2] [error] If applicable, you may wish to try moving some members into another object.
[specs2] [error] import MatchersImplicits._
[specs2] [error]        ^
[specs2] [info] No documentation generated with unsuccessful compiler run
[specs2] [error] four errors found
[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/NumericMatchers.scala:160:24: illegal cyclic reference involving trait NumericMatchers
[specs2] [error] object NumericMatchers extends NumericMatchers {
[specs2] [error]                        ^
[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/StringMatchers.scala:171:46: java.util.regex.MatchResult does not take type parameters
[specs2] [error]   implicit def toStringResultMatcher(result: MatchResult[String]) = new StringResultMatcher(result)
[specs2] [error]                                              ^
[specs2] [error] /Users/tisue/community.213/target-0.9.14/project-builds/specs2-55ced57bf67c31316040b6cca8f43edd36d6f8c3/matcher/shared/src/main/scala/org/specs2/matcher/StringMatchers.scala:172:37: java.util.regex.MatchResult does not take type parameters
[specs2] [error]   class StringResultMatcher(result: MatchResult[String]) {
[specs2] [error]                                     ^
[specs2] [error] four errors found
[specs2] [error] (matcherJVM / Compile / compileIncremental) Compilation failed
[specs2] [error] (matcherJVM / Compile / doc) Scaladoc generation failed
@etorreborre

This comment has been minimized.

Copy link
Owner

etorreborre commented Sep 27, 2018

Weird. I'll check that when other libraries are ready. I suspect that this is all fixable by tweaking the imports (hopefully!)

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Sep 29, 2018

kind-projector 0.9.8 is published for M5

@etorreborre

This comment has been minimized.

Copy link
Owner

etorreborre commented Sep 29, 2018

Thanks I think I'm only waiting on ScalaCheck now.

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 9, 2018

@etorreborre ScalaCheck 1.14.0 is now available for Scala 2.13.0-M5

@kpbochenek

This comment has been minimized.

Copy link

kpbochenek commented Oct 9, 2018

@SethTisue
I think according to this ticket rickynils/scalacheck#418 it is only published for jvm.
Dependency for specs2 is "org.scalacheck" %%% "scalacheck" % "1.14.0" % "test" which means you need scalajs too.

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 9, 2018

good point. I commented on that ticket asking whether there's some roadblock on the JS side

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 11, 2018

@etorreborre (if you have time to pursue this just on the JVM side, it would be helpful to have the needed fixes to unblock downstream projects in the 2.13 community build... even if you decide to hold off on any actual publishing until you can do JVM+JS at the same time)

@etorreborre

This comment has been minimized.

Copy link
Owner

etorreborre commented Oct 11, 2018

It is at least compiling now for 2.13.0-M5 but some tests, a few, are failing now because, I suspect, of some changes with the Scala collections. Unfortunately I don't have time to investigate that right now.

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 11, 2018

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 17, 2018

ScalaCheck has now been published for JS too

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 18, 2018

I see from @xuwei-k's comment at
spray/spray-json#275 (comment) that you published at least some M5 artifacts, is the status that JVM is done but JS is pending...?

@etorreborre

This comment has been minimized.

Copy link
Owner

etorreborre commented Oct 18, 2018

Yes indeed

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 26, 2018

@etorreborre anything we can help with here...?

if it helps at all, there's now Scala.js 1.0.0-M6 (and 0.6.25) for 2.13.0-M5

@etorreborre

This comment has been minimized.

Copy link
Owner

etorreborre commented Oct 26, 2018

I'm sick right now but I will check that and publish on Monday latest.

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 26, 2018

feel better! thanks for the update

@etorreborre

This comment has been minimized.

Copy link
Owner

etorreborre commented Oct 26, 2018

Ok, I released the missing JS artifacts for specs2-4.3.5 and scala 2.13.0-M5 from my bed except for the one needing cats-effect because the corresponding dependencies are not available yet.

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Oct 26, 2018

our hero! 🤒

@SethTisue

This comment has been minimized.

Copy link
Contributor

SethTisue commented Nov 27, 2018

I pinged the cats-effect crew at typelevel/cats-effect#66

@renatocaval renatocaval referenced this issue Dec 5, 2018

Open

Add 2.13.0-M5 build #8857

9 of 12 tasks complete
@mkurz

This comment has been minimized.

Copy link

mkurz commented Jan 9, 2019

cats-effect already published a release with Scala 2.13.0-M5 support:
typelevel/cats-effect#66 (comment)

@etorreborre

This comment has been minimized.

Copy link
Owner

etorreborre commented Jan 9, 2019

specs2-4.3.6 has been published now for Scala 2.13.0-M5, so we're good: https://oss.sonatype.org/content/repositories/releases/org/specs2/specs2-cats_2.13.0-M5/4.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment