Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quote from test of XML escape #754

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@ashawley
Copy link
Contributor

commented Jul 10, 2019

The plan in scala-xml 2.0 is to stop escaping quotation marks in XML element text (attribute text will still escape quotes).

XML element text is no longer being escaped with scala.xml.Utility.escape. Scala XML could probably have something added to provide parity with the two escape situations, but I'm not sure there's much value.

Remove quote from test of XML escape
The plan in scala-xml 2.0 is to stop escaping quotation marks in XML
element text (attribute text will still escape quotes).
@etorreborre

This comment has been minimized.

Copy link
Owner

commented Jul 10, 2019

Thanks

@etorreborre etorreborre merged commit 8575ee2 into etorreborre:master Jul 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ashawley ashawley referenced this pull request Jul 10, 2019

@ashawley ashawley deleted the ashawley:xml-escape branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.