Allow to determine the duration before retry according the retry number #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etorreborre
approved these changes
Sep 22, 2019
| /** @return a result that is retried at least 40 times until it's ok */ | ||
| def eventually[T : AsResult](result: =>T): T = | ||
| eventually(40, 100.millis)(result) | ||
| eventually(40, (_: Int) => 100.millis)(result) |
There was a problem hiding this comment.
You should be able to write eventually(40, 100.millis)(result) here, right?
There was a problem hiding this comment.
Yes, just prefer to directly call the more primitive variant
There was a problem hiding this comment.
Ok, that's fine. On the other hand most of the tests are not passing. Could you please investigate why?
| if (retries <= 1) { | ||
| r | ||
| def eventually[T : AsResult](retries: Int, sleep: Int => Duration)(result: =>T): T = { | ||
| @annotation.tailrec def retry(retried: Int): T = { |
|
|
||
| /** @return a matcher that will retry the nested matcher 40 times */ | ||
| def eventually[T](nested: =>Matcher[T]): Matcher[T] = eventually(nested, 40, 100.millis) | ||
| def eventually[T](nested: =>Matcher[T]): Matcher[T] = eventually(nested, 40, (_: Int) => 100.millis) |
There was a problem hiding this comment.
Here you should also be able to call eventually(nested, 40, 100.millis) directly
cchantep
force-pushed
the
feature/variable-retry-sleep
branch
from
270259a
to
2990bb8
Compare
cchantep
force-pushed
the
feature/variable-retry-sleep
branch
from
2990bb8
to
b62fb2f
Compare
|
All tests passing indeed, thanks! |
|
Thx @etorreborre for the quick review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage: