CLC-90 Add department code to class page feed #2

Merged
merged 1 commit into from Sep 4, 2012

Projects

None yet

1 participant

@raydavis
Member
raydavis commented Sep 4, 2012

No description provided.

@raydavis
Member
raydavis commented Sep 4, 2012

Updated to remove some unneeded changes.

@raydavis raydavis merged commit 4d1a625 into ets-berkeley-edu:master Sep 4, 2012
@ctweney ctweney pushed a commit that referenced this pull request Dec 5, 2012
Chris Tweney Squashed commit of the following:
commit 7921b36
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Wed Dec 5 09:34:26 2012 -0800

    CLC-696 Tweak log levels, set default log level back to WARN

commit b423ffd
Merge: 1645939 88478ab
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Wed Dec 5 09:04:11 2012 -0800

    Merge pull request #2 from yuhunglin/CLC-696

    Timezone aware fixes

commit 88478ab
Author: Yu-Hung Lin <yuhung@yuhunglin.com>
Date:   Wed Dec 5 05:44:32 2012 -0800

    fixes on element on edge case of day_after_tomorrow, not so wonderful fudging of google task dates

commit 6478bb5
Author: Yu-Hung Lin <yuhung@yuhunglin.com>
Date:   Wed Dec 5 04:08:29 2012 -0800

    fixes

commit 1645939
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 18:32:09 2012 -0800

    CLC-696 In test, instantiating starting_date as a Time object should make the test pass even when the machine is in UTC

commit 0d88d47
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 18:00:33 2012 -0800

    CLC-696 Using Date.civil instead of Date.new may give us the right GMT timezone

commit 3f5f4c0
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 17:42:00 2012 -0800

    CLC-696 Add more log to determine_bucket method

commit 567fe4c
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 17:23:08 2012 -0800

    CLC-696 Increase log level another way

commit 48fe04a
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 16:53:34 2012 -0800

    CLC-696 Log more chattily so I can see what's going on

commit 5cc1499
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 16:37:04 2012 -0800

    CLC-696 Attempt to fix Travis test

commit 3762aeb
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 16:22:54 2012 -0800

    CLC-696 Fix test

commit 9064462
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 16:15:39 2012 -0800

    CLC-696 Get all the Canvas data into task feed, and test it

commit 25e30c3
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 11:36:15 2012 -0800

    CLC-696 Make some CanvasProxy tests part of testext

commit 53aaf91
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 09:46:38 2012 -0800

    CLC-696 Make MyTasks model more object oriented

commit 8326291
Author: Chris Tweney <chris@media.berkeley.edu>
Date:   Tue Dec 4 09:20:08 2012 -0800

    CLC-696 Add coming_up feed to Canvas proxy
e17e9d4
@shacker shacker referenced this pull request in shacker/calcentral Dec 20, 2012
@shacker shacker CLC-909 Design refinements #2 5d7dd3e
@chikoon chikoon added a commit to chikoon/calcentral that referenced this pull request Apr 24, 2014
@chikoon chikoon CLC-3432: User alert feature can't handle diacriticals - PR #2
https://jira.ets.berkeley.edu/jira/browse/CLC-3432

Stopped using the magic header # encoding: utf-8
Stopped using Nokogiri for parsing the xml file since that's where the diacriticals were getting lost.
So, instead of using Nokogiri, I used the Hash.from_xml method which doesn't make a mess of the data encoding, namely UTF-8 which should be the standard encoding everywhere.
Updated specs to stop testing for Nokogiri parsing errors and replaced them with a test for detecting parsing errors that could be returned by Hash.from_xml.
Exceptions are muted and logged as errors.
9620b6d
@chikoon chikoon added a commit to chikoon/calcentral that referenced this pull request Apr 25, 2014
@chikoon chikoon CLC-3432: User alert feature can't handle diacriticals - PR #2
https://jira.ets.berkeley.edu/jira/browse/CLC-3432

Stopped using the magic header # encoding: utf-8
Stopped using Nokogiri for parsing the xml file since that's where the diacriticals were getting lost.
So, instead of using Nokogiri, I used the Hash.from_xml method which doesn't make a mess of the data encoding, namely UTF-8 which should be the standard encoding everywhere.
Updated specs to stop testing for Nokogiri parsing errors and replaced them with a test for detecting parsing errors that could be returned by Hash.from_xml.
Exceptions are muted and logged as errors.
c580f1a
@chikoon chikoon added a commit to chikoon/calcentral that referenced this pull request Apr 25, 2014
@chikoon chikoon CLC-3432: User alert feature can't handle diacriticals - PR #2
https://jira.ets.berkeley.edu/jira/browse/CLC-3432

Stopped using the magic header # encoding: utf-8
Stopped using Nokogiri for parsing the xml file since that's where the diacriticals were getting lost.
So, instead of using Nokogiri, I used the Hash.from_xml method which doesn't make a mess of the data encoding, namely UTF-8 which should be the standard encoding everywhere.
Updated specs to stop testing for Nokogiri parsing errors and replaced them with a test for detecting parsing errors that could be returned by Hash.from_xml.
Exceptions are muted and logged as errors.
afd6f4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment