Cannot import name 'Container' from 'dependency_injector.containers'

[ventaquil]

Hey!

I am trying to add type annotations to my Python code wherever I can. I created simple functions to init/shutdown resources in nested containers:

from dependency_injector.containers import Container
from dependency_injector.providers import Container as ContainerProvider


def init_resources(container: Container) -> NoReturn:
    container.init_resources()
    for provider in container.providers.values():
        if isinstance(provider, ContainerProvider):
            init_resources(provider)


def shutdown_resources(container: Container) -> NoReturn:
    container.shutdown_resources()
    for provider in container.providers.values():
        if isinstance(provider, ContainerProvider):
            shutdown_resources(provider)

I see that containers.pyi declares Container class but it seems that containers don't have Container parent at all.

I can prepare PR with abstract Container class.

[rmk135]

Hi @ventaquil ,

I see that containers.pyi declares Container class but it seems that containers don't have Container parent at all.

Yep, Container is just a typing stub, not a real class. I think creating just an empty class should be enough to keep using the stub for typing and not failing in runtime.

If you could make a pull request, it would be awesome. Use "develop" as a target branch.

[rmk135]

Btw, starting from version 4.14.0 you don't need to have these recursive functions. When you call .init_resources() on root container, it will initialize all nested resources. The same for shutdown. If you have other recursive functions, see new feature: https://python-dependency-injector.ets-labs.org/containers/traversal.html

[rmk135]

Fixed in 4.16.0. Thanks for reporting the problem. Closing the issue, re-open if needed.

[ventaquil]

I haven't time yet to do it on my own 😢

Thank you for fix and recommendations about .init_resources().

[rmk135]

I haven't time yet to do it on my own 😢

No worries! Thanks for finding time to report the issue. It helps to improve Dependency Injector.