New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New slack config option for username sender #146

Closed
quintanilhar opened this Issue Oct 10, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@quintanilhar
Contributor

quintanilhar commented Oct 10, 2017

Hi!

May we have a config key in Slack configuration array to use or not the previous configuration for the user sender instead of using the site name with an alert icon?

For example, in my case, I've configured an username with a customized icon for my token:
image

But I'm receiving new messages as:
image

The configuration could be:

/**
 * Slack
 *
 * Fill in to enable Slack integration.
 */
$config['slack'] = [
    /**
     * A webhook url to push Alerts to.
     * See https://api.slack.com/incoming-webhooks for details.
     */
    'webhook_url' => null,
    'override_username' => true // default value as true for avoiding backward compatible problems
];

What do you think about? I can send a PR with this. :)

@kiwiz

This comment has been minimized.

Show comment
Hide comment
@kiwiz

kiwiz Oct 14, 2017

Collaborator

Sounds reasonable! I can take a stab at this.

Collaborator

kiwiz commented Oct 14, 2017

Sounds reasonable! I can take a stab at this.

@kiwiz

This comment has been minimized.

Show comment
Hide comment
@kiwiz

kiwiz Oct 14, 2017

Collaborator

Implemented support for username and icon_emoji.

Collaborator

kiwiz commented Oct 14, 2017

Implemented support for username and icon_emoji.

@quintanilhar

This comment has been minimized.

Show comment
Hide comment
@quintanilhar

quintanilhar Oct 16, 2017

Contributor

I've tested your implementation and everything works properly.

Thank you @kiwiz!

Contributor

quintanilhar commented Oct 16, 2017

I've tested your implementation and everything works properly.

Thank you @kiwiz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment