New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display timestamps on the frontend in a configurable timezone #42

Closed
mareban opened this Issue Oct 4, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@mareban

mareban commented Oct 4, 2016

Is it possible to have time in CEST instead of GMT Please ?

Thanks for your help.

@AGirin

This comment has been minimized.

Show comment
Hide comment
@AGirin

AGirin Oct 4, 2016

It would be great that this is controlled by the browser time zone. I am on CST and this is really confusing to see time in GMT.

AGirin commented Oct 4, 2016

It would be great that this is controlled by the browser time zone. I am on CST and this is really confusing to see time in GMT.

@kiwiz

This comment has been minimized.

Show comment
Hide comment
@kiwiz

kiwiz Oct 4, 2016

Collaborator

I think this should be doable by modifying formatDate here: https://github.com/etsy/411/blob/master/htdocs/assets/js/util.js#L11

However, I'm unclear on the consequences. This is very low priority for me and a PR would be welcome!

Collaborator

kiwiz commented Oct 4, 2016

I think this should be doable by modifying formatDate here: https://github.com/etsy/411/blob/master/htdocs/assets/js/util.js#L11

However, I'm unclear on the consequences. This is very low priority for me and a PR would be welcome!

@kiwiz kiwiz changed the title from CEST instead of GMT to Display timestamps on the frontend in a configurable timezone Oct 4, 2016

@mareban

This comment has been minimized.

Show comment
Hide comment
@mareban

mareban Dec 14, 2016

We cannot use 411 in prod with GMT time ! It would be nice if we can have a solution please :) ?

Thanks for your help.

mareban commented Dec 14, 2016

We cannot use 411 in prod with GMT time ! It would be nice if we can have a solution please :) ?

Thanks for your help.

@kiwiz

This comment has been minimized.

Show comment
Hide comment
@kiwiz

kiwiz Dec 16, 2016

Collaborator

https://github.com/etsy/411/blob/master/htdocs/assets/js/util.js#L11-L16
If you replace toUTCString with toDateString, it might work.

Collaborator

kiwiz commented Dec 16, 2016

https://github.com/etsy/411/blob/master/htdocs/assets/js/util.js#L11-L16
If you replace toUTCString with toDateString, it might work.

@kiwiz

This comment has been minimized.

Show comment
Hide comment
@kiwiz

This comment has been minimized.

Show comment
Hide comment
@kiwiz

kiwiz Jun 2, 2017

Collaborator

Finished up frontend implementation. Remaining:

  • Templates (email)
  • Search statistics modal
  • Make sure we're consistent about formatting
Collaborator

kiwiz commented Jun 2, 2017

Finished up frontend implementation. Remaining:

  • Templates (email)
  • Search statistics modal
  • Make sure we're consistent about formatting

kiwiz added a commit that referenced this issue Jun 7, 2017

@kiwiz kiwiz self-assigned this Oct 27, 2017

@kiwiz kiwiz closed this Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment