Some fixes, some patches, some modifications, this should fix general use #11

Merged
merged 3 commits into from Sep 30, 2011

Projects

None yet

3 participants

Some fixes, some patches, some modifications, this should fix general users issues with git@ urls and diff being broken

Ryan Lewon added some commits Sep 29, 2011
@kastner kastner commented on an outdated diff Sep 29, 2011
@@ -155,9 +155,16 @@ module Deployinator
stack = params[:stack].to_sym
if Deployinator::Helpers.respond_to?(stack.to_s + "_git_repo_url")
repo_url = Deployinator::Helpers.send(stack.to_s + "_git_repo_url")
- parts = repo_url.split("/")
- user = parts[3]
- repo = parts[4].gsub(/\.git$/, "")
+ if repo_url == /https:\/\//
kastner
kastner Sep 29, 2011 Contributor

this regex should be anchord - /^htt...

and something's up with the whitespace on this line... hard tab by chance?

@kastner kastner merged commit f465168 into etsy:master Sep 30, 2011

I believe it should actually be if repo_url =~ /^https:///

@benburry benburry added a commit that referenced this pull request Jan 16, 2015
@benburry @jayson benburry + jayson Issue #11 - move lib/app.rb into gem 42cdd73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment