Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

TODO: Configurable Encoding #374

Closed
draco2003 opened this Issue Dec 6, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

draco2003 commented Dec 6, 2013

toString and new Buffer both can be passed an encoding type. If you aren't using non-ascii characters for metrics there is performance gains to be had.

toString:
https://github.com/etsy/statsd/blob/master/proxy.js#L40
https://github.com/etsy/statsd/blob/master/proxy.js#L52

new Buffer
https://github.com/etsy/statsd/pull/373/files#diff-ba25ea553e3ff05620224368284e4ae3R51

Owner

mrtazz commented Apr 14, 2014

any data on how much we could improve? I think supporting UTF-8 is fine unless it has a huge performance impact.

Owner

mrtazz commented Jan 22, 2015

the new buffer one was merged. closing this.

@mrtazz mrtazz closed this Jan 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment