Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

TODO: Configurable Encoding #374

Closed
draco2003 opened this Issue · 2 comments

2 participants

@draco2003

toString and new Buffer both can be passed an encoding type. If you aren't using non-ascii characters for metrics there is performance gains to be had.

toString:
https://github.com/etsy/statsd/blob/master/proxy.js#L40
https://github.com/etsy/statsd/blob/master/proxy.js#L52

new Buffer
https://github.com/etsy/statsd/pull/373/files#diff-ba25ea553e3ff05620224368284e4ae3R51

@mrtazz
Owner

any data on how much we could improve? I think supporting UTF-8 is fine unless it has a huge performance impact.

@mrtazz
Owner

the new buffer one was merged. closing this.

@mrtazz mrtazz closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.