Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Make it clearer that sampling is only for counters. #138

Merged
merged 1 commit into from

3 participants

@timblair

Sampling only applies to counters but the README wasn't clear on this. The text reads "Tells StatsD that this counter is being sent sampled" but the block is in between sections about timing and gauges, and at the same header level.

This is just a simple movement of text, and a change in the title style, to make it more obvious that sampling is only applicable to counters.

@travisbot

This pull request passes (merged 1c27489 into 5a36ca0).

@mrtazz
Owner

Thanks for the contribution!

@mrtazz mrtazz merged commit f4c6cf5 into from
@alexdean alexdean referenced this pull request in reinh/statsd
Closed

sample_rate should only be supported for counters. #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 7 deletions.
  1. +5 −7 README.md
View
12 README.md
@@ -30,6 +30,11 @@ Counting
This is a simple counter. Add 1 to the "gorets" bucket. It stays in memory until the flush interval `config.flushInterval`.
+### Sampling
+
+ gorets:1|c|@0.1
+
+Tells StatsD that this counter is being sent sampled every 1/10th of the time.
Timing
------
@@ -48,13 +53,6 @@ generate the following list of stats for each threshold:
Where `$KEY` is the key you stats key you specify when sending to statsd, and
`$PCT` is the percentile threshold.
-Sampling
---------
-
- gorets:1|c|@0.1
-
-Tells StatsD that this counter is being sent sampled every 1/10th of the time.
-
Gauges
------
StatsD now also supports gauges, arbitrary values, which can be recorded.
Something went wrong with that request. Please try again.