Fix for config.js, fs.watchFile doesn't work #145

Merged
merged 1 commit into from Oct 20, 2012

Conversation

Projects
None yet
4 participants
@diegovar

When running I get the following error:

fs.js:747
throw new Error('use fs.watch api instead');
^
Error: use fs.watch api instead
at Object.watchFile (fs.js:747:11)
at new (c:\git\platform-statsd\config.js:24:6)
at Object.configFile (c:\git\platform-statsd\config.js:34:16)
at Object. (c:\git\platform-statsd\stats.js:77:8)
at Module._compile (module.js:446:26)
at Object..js (module.js:464:10)
at Module.load (module.js:353:31)
at Function._load (module.js:311:12)
at Array.0 (module.js:484:10)
at EventEmitter._tickCallback (node.js:190:38)

Using fs.watch fixes this issue.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Aug 20, 2012

This pull request passes (merged 19814bd into 4bd7597).

This pull request passes (merged 19814bd into 4bd7597).

@mrtazz mrtazz merged commit 19814bd into etsy:master Oct 20, 2012

1 check passed

default The Travis build passed
Details
@mrtazz

This comment has been minimized.

Show comment Hide comment
@mrtazz

mrtazz Oct 20, 2012

Member

Thanks for the patch.

Member

mrtazz commented Oct 20, 2012

Thanks for the patch.

@kigster

This comment has been minimized.

Show comment Hide comment
@kigster

kigster Oct 20, 2012

When you say "fix", you mean you broke it for node 0.6.6 on Solaris :)

When you say "fix", you mean you broke it for node 0.6.6 on Solaris :)

@mrtazz

This comment has been minimized.

Show comment Hide comment
@mrtazz

mrtazz Oct 20, 2012

Member

The CI build passed on node 0.6.21-pre, which is why I merged it. Is there a reason not to update? I know it sucks to ask for updates, but it is also almost impossible to test on all outdated versions.

Member

mrtazz commented Oct 20, 2012

The CI build passed on node 0.6.21-pre, which is why I merged it. Is there a reason not to update? I know it sucks to ask for updates, but it is also almost impossible to test on all outdated versions.

@kigster

This comment has been minimized.

Show comment Hide comment
@kigster

kigster Nov 5, 2012

Just to close the loop, sorry I get now that you support latest 0.6.X version, that makes total sense. We'll upgrade ours.

kigster commented Nov 5, 2012

Just to close the loop, sorry I get now that you support latest 0.6.X version, that makes total sense. We'll upgrade ours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment