Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Increments bad_lines_seen when sampleRate bit does not match regex #150

Merged
merged 1 commit into from Oct 20, 2012

Conversation

Projects
None yet
3 participants

smreed commented Aug 29, 2012

Not sure if this is what the intent behind "bad_lines_seen" is, but I know it definitely would've helped me when troubleshooting a problem sending stats from my (albeit buggy) customer client code.

This change will write to the log and increment bad_lines_seen if the bit in the |-delimited stat does not match the decimal regex.

This pull request passes (merged 6762a41 into 4bd7597).

Owner

mrtazz commented Oct 20, 2012

Yes, great idea. Thanks for the patch!

@mrtazz mrtazz added a commit that referenced this pull request Oct 20, 2012

@mrtazz mrtazz Merge pull request #150 from smreed/log-bad-sample-rate
Increments bad_lines_seen when sampleRate bit does not match regex
ba1d0c6

@mrtazz mrtazz merged commit ba1d0c6 into etsy:master Oct 20, 2012

@hbouvier hbouvier pushed a commit to hbouvier/statsd that referenced this pull request May 25, 2013

@mrtazz mrtazz Merge pull request #150 from smreed/log-bad-sample-rate
Increments bad_lines_seen when sampleRate bit does not match regex
f4a3f81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment