Relax metric name sanitation based on a configuration flag #154

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@mjr5749

This is not a general fix for #110, but it does provide a way to accomplish one of the use cases described in the issue:

For example, in the case of the Librato backend we would like a way to specify a
custom source parameter on a stat by stat basis. One thought would be to use a
prefix character, like (/), to separate the source name from the metric name

This flag can be used in conjunction with this patch to the librato-statsd-backend:
librato/statsd-librato-backend#8

@mjr5749 mjr5749 Add a new top-level config flag 'relaxMetricNameSanitation' (default …
…false) that allows '/' characters in metric names to be preserved and passed through to backend plugins when metrics are flushed.
a1a97ef
@mjr5749 mjr5749 referenced this pull request in librato/statsd-librato-backend Sep 14, 2012
Closed

Feature/per-metric source name #8

@mheffner

If someone wants to use the Librato backend and the Graphite backend simultaneously, won't this cause problems for Graphite if they set the config true? I'd say we probably want to stick with pushing this down to the backend. That way if someone has the metric name "eth0.packets.in/foo1.com", it could appear as <name=eth0.packets.in, source=foo1.com> in Librato's backend and simply name=eth0.packets.in.foo1.com in Graphite.

@mrtazz
Etsy, Inc. member

I agree with @mheffner here. I think pushing the sanitization into the backends is the better solution.

@mrtazz
Etsy, Inc. member

Closing this in favour of #155

@mrtazz mrtazz closed this Oct 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment