Fixes Issues #188 - repeater can be configured for udp6, defaults to udp4 #190

Merged
merged 1 commit into from Nov 3, 2012

Projects

None yet

2 participants

@sax
Contributor
sax commented Nov 3, 2012

Although repeaters default to udp4, this allows users to configure for udp6.

@mrtazz
Member
mrtazz commented Nov 3, 2012

I thought we decided in #188 that we want to decide between v4/v6 on a per-repeater level with default set to v4? I'm not sure if there is even a use case for this, so this patch might also be fine.

@sax
Contributor
sax commented Nov 3, 2012

Yeah, I was about to commit a patch that did so, but the more I thought about it, the more I figured you would just want one or the other.

The alternative would be this: sax@d37beb5

@mrtazz
Member
mrtazz commented Nov 3, 2012

I agree, the other option is much more complicated for a use case that probably doesn't exist.

@mrtazz mrtazz merged commit a714db4 into etsy:master Nov 3, 2012

1 check passed

default The Travis build passed
Details
@sax
Contributor
sax commented Nov 3, 2012

Awesome, thanks for merging it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment