Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

package.json "engines" #191

Merged
merged 1 commit into from Nov 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

themgt commented Nov 4, 2012

https://npmjs.org/doc/json.html specifies "engines" while the current code uses the "engine" key. This causes problems e.g. on Heroku/Pogoapp using the node.js buildpack, which looks for "engines" key to figure out what version of node to vendor in

Owner

mrtazz commented Nov 4, 2012

Good catch, thanks for the patch!

mrtazz added a commit that referenced this pull request Nov 4, 2012

@mrtazz mrtazz merged commit 69f1a3c into etsy:master Nov 4, 2012

1 check passed

default The Travis build passed
Details

hbouvier pushed a commit to hbouvier/statsd that referenced this pull request May 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment