Delete folder of metrics with: delcounters parent.path.* #246

Merged
merged 3 commits into from Apr 11, 2013

Conversation

Projects
None yet
3 participants
@carver
Contributor

carver commented Feb 10, 2013

Sorry this doesn't include tests. I manually confirmed that this works on counters, gauges, and timers.

Some Bonuses:

  • A minor refactor of the delete code in the management server. The five repeated lines for every delete command are now one.
  • The management server now warns you when you try to delete something, but it wasn't there yet.

I didn't add anything more complex like regex, because I didn't like the idea of having to escape the dots when issuing commands. This seems simple and to cover a lot of cases.

@mrtazz

This comment has been minimized.

Show comment Hide comment
@mrtazz

mrtazz Feb 11, 2013

Owner

Awesome! Can you add documentation to the functions (brief description, parameters and return values)? Can be as informal as tomdoc. We also should add tests to this since the functions now make it easily testable. I've been thinking about moving the management server into its own module anyways and this is a pretty good start.

Owner

mrtazz commented Feb 11, 2013

Awesome! Can you add documentation to the functions (brief description, parameters and return values)? Can be as informal as tomdoc. We also should add tests to this since the functions now make it easily testable. I've been thinking about moving the management server into its own module anyways and this is a pretty good start.

@carver

This comment has been minimized.

Show comment Hide comment
@carver

carver Feb 26, 2013

Contributor

@mrtazz I added a management console library file and a few tests. Looks ready to merge.

Contributor

carver commented Feb 26, 2013

@mrtazz I added a management console library file and a few tests. Looks ready to merge.

@mrtazz

This comment has been minimized.

Show comment Hide comment
@mrtazz

mrtazz Mar 23, 2013

Owner

looks good so far. Sorry for the delay on this. Would you mind basing this on the newest master?

Owner

mrtazz commented Mar 23, 2013

looks good so far. Sorry for the delay on this. Would you mind basing this on the newest master?

@carver

This comment has been minimized.

Show comment Hide comment
@carver

carver Mar 24, 2013

Contributor

no worries. rebased.

Contributor

carver commented Mar 24, 2013

no worries. rebased.

draco2003 added a commit that referenced this pull request Apr 11, 2013

Merge pull request #246 from carver/delete-group
Delete folder of metrics with: delcounters parent.path.*

@draco2003 draco2003 merged commit da85244 into etsy:master Apr 11, 2013

1 check passed

default The Travis build passed
Details
@draco2003

This comment has been minimized.

Show comment Hide comment
@draco2003

draco2003 Apr 11, 2013

Contributor

Thanks for this!

Contributor

draco2003 commented Apr 11, 2013

Thanks for this!

@carver

This comment has been minimized.

Show comment Hide comment
@carver

carver Apr 11, 2013

Contributor

You bet!
On Apr 11, 2013 2:46 PM, "Dan Rowe
notifications-at-github.com|github/Example Allow|" <
nyidmla5wt@sneakemail.com> wrote:

Thanks for this!


Reply to this email directly or view it on GitHubhttps://github.com/etsy/statsd/pull/246#issuecomment-16263799
.

Contributor

carver commented Apr 11, 2013

You bet!
On Apr 11, 2013 2:46 PM, "Dan Rowe
notifications-at-github.com|github/Example Allow|" <
nyidmla5wt@sneakemail.com> wrote:

Thanks for this!


Reply to this email directly or view it on GitHubhttps://github.com/etsy/statsd/pull/246#issuecomment-16263799
.

hbouvier pushed a commit to hbouvier/statsd that referenced this pull request May 25, 2013

Merge pull request #246 from carver/delete-group
Delete folder of metrics with: delcounters parent.path.*

@carver carver deleted the carver:delete-group branch Mar 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment