Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete folder of metrics with: delcounters parent.path.* #246

Merged
merged 3 commits into from Apr 11, 2013

Conversation

carver
Copy link
Contributor

@carver carver commented Feb 10, 2013

Sorry this doesn't include tests. I manually confirmed that this works on counters, gauges, and timers.

Some Bonuses:

  • A minor refactor of the delete code in the management server. The five repeated lines for every delete command are now one.
  • The management server now warns you when you try to delete something, but it wasn't there yet.

I didn't add anything more complex like regex, because I didn't like the idea of having to escape the dots when issuing commands. This seems simple and to cover a lot of cases.

@mrtazz
Copy link
Member

mrtazz commented Feb 11, 2013

Awesome! Can you add documentation to the functions (brief description, parameters and return values)? Can be as informal as tomdoc. We also should add tests to this since the functions now make it easily testable. I've been thinking about moving the management server into its own module anyways and this is a pretty good start.

@carver
Copy link
Contributor Author

carver commented Feb 26, 2013

@mrtazz I added a management console library file and a few tests. Looks ready to merge.

@mrtazz
Copy link
Member

mrtazz commented Mar 23, 2013

looks good so far. Sorry for the delay on this. Would you mind basing this on the newest master?

@carver
Copy link
Contributor Author

carver commented Mar 24, 2013

no worries. rebased.

draco2003 added a commit that referenced this pull request Apr 11, 2013
Delete folder of metrics with: delcounters parent.path.*
@draco2003 draco2003 merged commit da85244 into statsd:master Apr 11, 2013
@draco2003
Copy link
Contributor

Thanks for this!

@carver
Copy link
Contributor Author

carver commented Apr 11, 2013

You bet!
On Apr 11, 2013 2:46 PM, "Dan Rowe
notifications-at-github.com|github/Example Allow|" <
nyidmla5wt@sneakemail.com> wrote:

Thanks for this!


Reply to this email directly or view it on GitHubhttps://github.com//pull/246#issuecomment-16263799
.

hbouvier pushed a commit to hbouvier/statsd that referenced this pull request May 25, 2013
Delete folder of metrics with: delcounters parent.path.*
@carver carver deleted the delete-group branch March 7, 2014 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants