Update helpers.js #363

Closed
wants to merge 4 commits into
from

2 participants

@moffetb

The change to the gauge setting allows using exponent format for the gauge. It should (if I remember by regex correctly) allow for
[+-]\d.\d+e[+-]\d+ in addition to handling the normal \d+.\d+ for floating point.

moffetb Update helpers.js
The change to the gauge setting allows using exponent format for the gauge.  It should (if I remember by regex correctly) allow for 
[+-]\d.\d+e[+-]\d+ in addition to handling the normal \d+.\d+ for floating point.
3ec0d60
@mrtazz
Etsy, Inc. member

Hey can you document some examples of scientific notation in the source code so that it's clear what it's parsing? Because the regex is not really easy to parse :). Also the tests are failing so something is probably broken. It would also be awesome to have tests around this new addition.

moffetb added some commits Nov 22, 2013
moffetb Update helpers.js
rather than try and combine everything into a single regex, decided to keep the original and add an addition regex test.

The test harness will be updated soon to check for these.
588ee6b
moffetb Update helpers_tests.js a0812af
moffetb Update helpers.js
Forgot the beginning of line for completeness sake.
8c48731
@mrtazz
Etsy, Inc. member

closed by #382

@mrtazz mrtazz closed this Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment