Allow for aliasing the different timer metrics #393

Open
wants to merge 3 commits into
from

Projects

None yet

2 participants

@quirkey
quirkey commented Feb 10, 2014

These can be set as needed in the config file and use the existing settings as the defaults.

Up until this point we've been using a fork of statsd @paperlesspost that was forked VERY early on and went in a different direction for a while. We want to get back up to trunk, but without being able to alias these new timer metrics, we lose consistency between our current metrics and would have to either migrate a lot of files, or just start from scratch. This gives us (and probably other people) the best of both worlds, being able to use statsd but having our uppers called max's and etc.

@quirkey quirkey Allow for aliasing the different timer metrics
These can be set as needed in the config file and use the existing
settings as the defaults
3110d0e
Owner
mrtazz commented Feb 10, 2014

Hey thanks for the pull request! If I understand correctly, this is basically just metrics naming cosmetics presumably for Graphite? In that case it would make much more sense to have that option in the backend, since it shouldn't matter how they are called internally while processing metrics. Or am I missing something there?

quirkey commented Feb 10, 2014

@mrtazz Maybe I'm missing something, but it seems like in the current setup, process_metrics is called for any backend? In this case these are global aliases, not per-backend

Owner
mrtazz commented Feb 11, 2014

right it's the function for internal metrics processing. I was just thinking about whether naming metrics should even be a concern of the processing part or if it makes more sense to have each backend decide how data should be sent. Kind of related to #155

quirkey commented Feb 18, 2014

@mrtazz OK! I guess I'll wait for that work to be merged. In the meantime we're using this in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment