Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Removed Standard Passwordfile.
  • Loading branch information
SchulzeStTSI committed Oct 28, 2021
1 parent 30b9d92 commit 124ddf3
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion Dockerfile
Expand Up @@ -9,6 +9,5 @@ RUN yarn && yarn build
FROM nginx:1.19.10 as app
COPY --from=build ./app/build /usr/share/nginx/html
COPY nginx/default.conf.template /etc/nginx/templates/default.conf.template
COPY nginx/.htpasswd /etc/nginx/.htpasswd

This comment has been minimized.

Copy link
@mario19812021

mario19812021 Oct 31, 2021

aereo

This comment has been minimized.

Copy link
@Bastian82

Bastian82 Nov 1, 2021

congrats!! lol

ENV SERVER_PORT=80
ENV DGCA_ISSUANCE_SERVICE_URL=http://localhost:8080
1 change: 0 additions & 1 deletion nginx/.htpasswd

This file was deleted.

2 changes: 0 additions & 2 deletions nginx/default.conf.template
Expand Up @@ -2,8 +2,6 @@ server {
listen ${SERVER_PORT};
server_tokens off;
location / {
auth_basic "Secured Site";
auth_basic_user_file /etc/nginx/.htpasswd;
root /usr/share/nginx/html;
index unresolvable-file-html.html;
try_files $uri @index;
Expand Down

6 comments on commit 124ddf3

@0ki
Copy link

@0ki 0ki commented on 124ddf3 Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this better? Now we're gonna have people plopping this on their servers and it won't even have a default password. Just plain open.

@slonka
Copy link

@slonka slonka commented on 124ddf3 Oct 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add nginx/.htpasswd to gitignore.
  2. Generate a new password.
  3. Put it back in nginx/.htpasswd (or some other place)
  4. Restore the config.
  5. Read an article on how to (not) store passwords in git.

@0ki
Copy link

@0ki 0ki commented on 124ddf3 Oct 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this have to do with this change, @emidimauro ?

@emidimauro
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry

@marcorossi309080
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't install it ... i can only see a template with a spinning wheel. I cannot add yarn build on the terminal as it gives me an error with the proxy. i tried to switch from localhost: 3000 to localhost: 8000 but no results. can someone help me with the installation? thanks a lot

@0ki
Copy link

@0ki 0ki commented on 124ddf3 Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What leads you to believe that this commit broke it?

Please sign in to comment.