Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination & Ratelimiting #4

Open
winny- opened this issue May 21, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@winny-
Copy link

commented May 21, 2018

It appears the Link (for pagination) and X-RateLimit-* headers are discarded and not inserted into github-response structs. I'm not sure if you're still maintaining this repo, but figured I'd open a ticket anyway :)

My first thought would be to extend the struct with two more fields, but unfortunately that'd probably break some existing code - such as using the struct match expander on github-response structs.

Another option could be to make a new struct that inherits from github-response, but this could get messy.

Finally the backwards compatibility could be ignored ☠️ - but I don't think this is the best bet.

@eu90h

This comment has been minimized.

Copy link
Owner

commented Sep 11, 2018

Hey, thanks for letting me know about this. I'll take a look at it soon. Sorry about the wait.

@pmatos

This comment has been minimized.

Copy link

commented Jan 23, 2019

I noticed this as well. While displaying all the issues for racket/racket you only get 30 results and no way to find next page. @eu90h will you have time to look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.