Skip to content
Browse files

Fixes EUCA-3962 where a forward NULL has been detected. Fixes Coverity

issue #10988.
  • Loading branch information...
1 parent 004262d commit 7f5416a16844ebd19395b7ec2601c30ab6b4ff31 @gelinasc gelinasc committed Nov 21, 2012
Showing with 2 additions and 3 deletions.
  1. +2 −3 util/fault.c
View
5 util/fault.c
@@ -319,7 +319,7 @@ check_eucafault_suppression (const char *fault_id, const char *fault_file)
if (fault_file == NULL) {
// Degenerate case.
return is_suppressed_eucafault (fault_id);
- } else {
+ } else if (fault_id != NULL){
if (is_suppressed_eucafault (fault_id)) {
logprintfl (EUCATRACE, "Detected already-suppressed fault id %s\n", fault_id);
return TRUE;
@@ -354,8 +354,7 @@ check_eucafault_suppression (const char *fault_id, const char *fault_file)
return FALSE;
}
}
- logprintfl (EUCATRACE, "returning FALSE for %s, %s\n",
- fault_id, fault_file);
+ logprintfl (EUCATRACE, "returning FALSE for %s, %s\n", SP(fault_id), SP(fault_file));
return FALSE;
}

0 comments on commit 7f5416a

Please sign in to comment.
Something went wrong with that request. Please try again.