New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falafel's package.json is broken and it seems to be abandoned. #29

Closed
bobthecow opened this Issue Feb 28, 2014 · 9 comments

Comments

Projects
None yet
4 participants
@bobthecow
Copy link
Collaborator

bobthecow commented Feb 28, 2014

See:

substack/node-falafel#24
substack/node-falafel#29
https://github.com/substack/node-falafel/issues

In its current state, it can't be used with npm shrinkwrap, and I'm having trouble using it on Heroku at all (i'm guessing the node buildpack runs npm prune?).

Is there any way to switch to something else? Or fork it and apply the patch and depend on that one for now?

@wheresrhys

This comment has been minimized.

Copy link
Collaborator

wheresrhys commented Feb 28, 2014

My temporary fix for this is to remove debowerify from package.json and npm uninstall debowerify then npm shrinkwrap --dev then add this json to npm-shrinkwrap.json. Then npm install. The above steps will need repeating every time you change your dependencies.

I've started to pester substack via an issue on a repo he is actively maintaining - feel free to be a co-pesterer browserify/browser-unpack#4. 5 months without response on an issue which someone else has fixed and which impacts on developers' use of other modules isn't good.

@khaled

This comment has been minimized.

Copy link

khaled commented Mar 1, 2014

My temporary fix was to depend on my forked debowerify, which in turn depends on a forked falafel that is patched with a corrected package.json.

@bobthecow

This comment has been minimized.

Copy link
Collaborator

bobthecow commented Mar 1, 2014

@khaled yeah, my hope was that i could bypass forking debowerify by opening this issue :)

@wheresrhys

This comment has been minimized.

Copy link
Collaborator

wheresrhys commented Nov 12, 2014

@eugeneware do you plan on addressing this issue any time?

@eugeneware

This comment has been minimized.

Copy link
Owner

eugeneware commented Nov 13, 2014

Hi Guys, I'm not really using this module that much, but will happily take Pull Requests. @bobthecow would you like to to a PR? Alternatively you could rewrite to not use felafel.

@bobthecow

This comment has been minimized.

Copy link
Collaborator

bobthecow commented Nov 17, 2014

Rewriting to not use falafel would prolly be the best call at this point, given the current state of falafel development :)

@eugeneware

This comment has been minimized.

Copy link
Owner

eugeneware commented Nov 17, 2014

@bobthecow Most likely. In the meantime, could you do a PR so we can move away from having to fork? :-)

@bobthecow

This comment has been minimized.

Copy link
Collaborator

bobthecow commented Nov 20, 2014

@eugeneware I just went the "ditch falafel" route. See #52 :)

@eugeneware

This comment has been minimized.

Copy link
Owner

eugeneware commented Nov 21, 2014

Thanks @bobthecow for the great work! This is published now as 1.0.1. This should close out this long-standing issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment