Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template review feedback #1

Closed
praveena-pappu opened this issue Dec 8, 2020 · 1 comment
Closed

Template review feedback #1

praveena-pappu opened this issue Dec 8, 2020 · 1 comment
Assignees

Comments

@praveena-pappu
Copy link

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

  1. encodeUri should be used on user provided values that are then used as your url. These methods take in a single text argument and returns an encoded Uniform Resource Identifier (URI) by escaping special characters. They return a string that represents the provided string encoded as a URI. You should use this method on "trackingDomain" when generating the url
    const url = 'https://'+ trackingDomain +'/ea.js';
matjmat added a commit that referenced this issue Dec 9, 2020
@matjmat
Copy link
Contributor

matjmat commented Dec 9, 2020

fixed

@matjmat matjmat closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants