New mswin .ico icon. #9

Merged
merged 2 commits into from Jun 10, 2011

Conversation

Projects
None yet
2 participants
Contributor

dtf commented Jun 10, 2011

No description provided.

@dtf dtf commented on the diff Jun 10, 2011

.../winintegration/subplugins/win7taskbar/thumbnails.cpp
@@ -34,7 +34,7 @@
using namespace qutim_sdk_0_3;
WThumbnails::WThumbnails()
- : pp(0), chatWindow(0), tabId(0)
+ : chatWindow(0), tabId(0), pp(0)
@dtf

dtf Jun 10, 2011

Contributor

Funny? MinGW warning was here.

@euroelessar euroelessar commented on an outdated diff Jun 10, 2011

...ration/subplugins/win7taskbar/thumbnails-renderer.cpp
#include <qt_windows.h>
using namespace qutim_sdk_0_3;
-typedef HRESULT (WINAPI * DwmGetColorizationColor_t)(DWORD*, BOOL*);
-DwmGetColorizationColor_t pDwmGetColorizationColor = 0;
+typedef LONG (WINAPI * RegGetValueA_t)(HKEY, const char*const, const char*const, DWORD, LPDWORD, PVOID, LPDWORD);
+static RegGetValueA_t pRegGetValueA = (RegGetValueA_t)QLibrary("advapi32").resolve("RegGetValueA");
@euroelessar

euroelessar Jun 10, 2011

Owner

In case of static build QLibrary, which is successor of QObject, will be created before QApplication which will cause assertion fail

@euroelessar euroelessar added a commit that referenced this pull request Jun 10, 2011

@euroelessar euroelessar Merge pull request #9 from dtf/master
New mswin .ico icon.
1b1cd1b

@euroelessar euroelessar merged commit 1b1cd1b into euroelessar:master Jun 10, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment