Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add argument to defun #116

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@YoheiKakiuchi
Copy link
Member

commented Jul 7, 2015

add argument to defun for adding documentation string to functions written by C
This is another implementation of
#111

for using variable arguments we must know number of arguments.

@garaemon

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2015

Is it possible to use va_list to keep compatibility?
http://www.cprogramming.com/tutorial/c/lesson17.html

@YoheiKakiuchi

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2015

for using va_list we must know number of arguments.
if using defun by legacy style, va_arg may return incorrect pointer (it's not char *) from stack.
we have no way to check pointer is char * or not.

@k-okada

This comment has been minimized.

Copy link
Member

commented Jul 8, 2015

wow, this is very tricky but seems to work well.
+1

mmurooka pushed a commit to mmurooka/EusLisp that referenced this pull request Jan 4, 2018

@k-okada

This comment has been minimized.

Copy link
Member

commented Jul 11, 2018

@YoheiKakiuchi can we merge this?

@YoheiKakiuchi

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2018

Yes.

@k-okada k-okada merged commit d7a3284 into euslisp:master Jul 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

k-okada added a commit to k-okada/jskeus that referenced this pull request Jul 18, 2018

k-okada added a commit to k-okada/jskeus that referenced this pull request Jul 18, 2018

k-okada added a commit to euslisp/jskeus that referenced this pull request Jul 18, 2018

Merge pull request #511 from k-okada/fix_defun
update function using defun() for euslisp/EusLisp#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.