Skip to content

Update setup.py to latest click version#170

Merged
krnick merged 1 commit into
ev-flow:masterfrom
Dil3mm3:master
May 31, 2021
Merged

Update setup.py to latest click version#170
krnick merged 1 commit into
ev-flow:masterfrom
Dil3mm3:master

Conversation

@Dil3mm3

@Dil3mm3 Dil3mm3 commented May 29, 2021

Copy link
Copy Markdown
Contributor

Hi all,

Testing Quark we noticed that, without forcing Click to the latest version (8.0.1) in the Setup.py file, the attribute flag_value, inserted to let the options -s and -d take zero or more arguments, is not working. For this reason, I just changed the Setup.py and Click version. Everything should work correctly now 😄

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #170 (5b5fdc2) into master (28fd970) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files          35       35           
  Lines        1554     1554           
=======================================
  Hits         1139     1139           
  Misses        415      415           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fd970...5b5fdc2. Read the comment docs.

@krnick krnick self-assigned this May 31, 2021
@krnick

krnick commented May 31, 2021

Copy link
Copy Markdown
Contributor

Hello @Dil3mm3,

Thank you for pointing out this problem!

I have tested pip3 install click, pipenv install click, and pip3 install quark-engine, the default click version of these three commands is 8.0.1, which is now the latest version.

Please help me to check whether your current installation of click is the same. If so, we don’t need to specify the version number.

https://pypi.org/project/click/#history

Thank you 😄

@18z

18z commented May 31, 2021

Copy link
Copy Markdown
Member

Hi @Dil3mm3

Thanks for the PR!

I think it's important to lock the version of modules we use in the setup.py.

And I suggest the policy of version locking is:

  1. We tested the latest version first and make sure the latest version works and is stable as the previous version.
  2. And then, we bump the version to the latest stable one.

Thanks again for reminding us!

@18z 18z self-assigned this May 31, 2021
@18z 18z self-requested a review May 31, 2021 09:33
@18z

18z commented May 31, 2021

Copy link
Copy Markdown
Member

We do have some other friends encounter this problem! Thanks @Dil3mm3 for fixing this up! :D

@krnick krnick self-requested a review May 31, 2021 09:34

@18z 18z left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :D

@18z 18z added the dependencies Pull requests that update a dependency file label May 31, 2021

@krnick krnick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood that the latest version will be installed by default, but later found out that this is not the case. Thank you @Dil3mm3 for solving this problem.

@krnick krnick merged commit c91f081 into ev-flow:master May 31, 2021
@Dil3mm3

Dil3mm3 commented Jun 2, 2021

Copy link
Copy Markdown
Contributor Author

You're welcome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants