Fix Quark rules not matching when no spaces between arguments.#249
Conversation
|
Hello @haeter525! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-03 11:23:33 UTC |
143a4b2 to
28a7a1e
Compare
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 80.09% 80.32% +0.23%
==========================================
Files 49 49
Lines 3481 3523 +42
==========================================
+ Hits 2788 2830 +42
Misses 693 693
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
28a7a1e to
48d87d4
Compare
|
Hi @haeter525, can you describe how you solved this problem? |
|
Hi @pulorsok , The solution is simple. |
|
LGTM! |
Description
Refer to #138
This PR inserts additional spaces into those APIs that don't have spaces in the arguments. The adjustment happens when Quark loading a JSON rule.
Code changes
Test plan