Skip to content

Add new feature for generate Quark web report#345

Merged
haeter525 merged 13 commits into
ev-flow:masterfrom
pulorsok:webreport
May 18, 2022
Merged

Add new feature for generate Quark web report#345
haeter525 merged 13 commits into
ev-flow:masterfrom
pulorsok:webreport

Conversation

@pulorsok

Copy link
Copy Markdown
Member

Add new feature for generate Quark report.
With the following command, we can easily analyze the Android sample and output the web report.

See the demo here.

quark -a sample.apk -s -w quark_report.html

@pep8speaks

pep8speaks commented May 18, 2022

Copy link
Copy Markdown

Hello @pulorsok! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 30:80: E501 line too long (81 > 79 characters)
Line 124:80: E501 line too long (81 > 79 characters)
Line 139:80: E501 line too long (81 > 79 characters)
Line 151:80: E501 line too long (87 > 79 characters)
Line 158:80: E501 line too long (95 > 79 characters)
Line 164:80: E501 line too long (83 > 79 characters)
Line 174:80: E501 line too long (111 > 79 characters)
Line 180:80: E501 line too long (91 > 79 characters)
Line 234:80: E501 line too long (95 > 79 characters)
Line 240:80: E501 line too long (82 > 79 characters)
Line 258:80: E501 line too long (181 > 79 characters)
Line 260:80: E501 line too long (92 > 79 characters)
Line 262:80: E501 line too long (224 > 79 characters)
Line 265:80: E501 line too long (93 > 79 characters)
Line 266:80: E501 line too long (85 > 79 characters)
Line 267:80: E501 line too long (198 > 79 characters)
Line 268:80: E501 line too long (197 > 79 characters)
Line 269:80: E501 line too long (197 > 79 characters)
Line 270:80: E501 line too long (194 > 79 characters)
Line 271:80: E501 line too long (197 > 79 characters)
Line 272:80: E501 line too long (197 > 79 characters)
Line 277:80: E501 line too long (118 > 79 characters)
Line 281:80: E501 line too long (85 > 79 characters)
Line 282:80: E501 line too long (81 > 79 characters)
Line 283:80: E501 line too long (82 > 79 characters)
Line 286:80: E501 line too long (81 > 79 characters)
Line 287:80: E501 line too long (85 > 79 characters)

Comment last updated at 2022-05-18 09:20:46 UTC

@pulorsok pulorsok requested a review from haeter525 May 18, 2022 06:03
@pulorsok pulorsok linked an issue May 18, 2022 that may be closed by this pull request
@lgtm-com

lgtm-com Bot commented May 18, 2022

Copy link
Copy Markdown

This pull request introduces 11 alerts when merging d066b68 into cf8a90f - view on LGTM.com

new alerts:

  • 11 for Missing variable declaration

@lgtm-com

lgtm-com Bot commented May 18, 2022

Copy link
Copy Markdown

This pull request introduces 11 alerts when merging 3ef6d0d into cf8a90f - view on LGTM.com

new alerts:

  • 11 for Missing variable declaration

@codecov-commenter

codecov-commenter commented May 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #345 (e868f6a) into master (cf8a90f) will decrease coverage by 1.68%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   78.77%   77.09%   -1.69%     
==========================================
  Files          50       51       +1     
  Lines        3704     3785      +81     
==========================================
  Hits         2918     2918              
- Misses        786      867      +81     
Flag Coverage Δ
unittests 77.09% <0.00%> (-1.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quark/cli.py 0.00% <0.00%> (ø)
quark/core/quark.py 70.16% <ø> (ø)
quark/webreport/generate.py 0.00% <0.00%> (ø)
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8a90f...e868f6a. Read the comment docs.

Comment thread quark/cli.py Outdated
Comment thread quark/webreport/generate.py Outdated
@lgtm-com

lgtm-com Bot commented May 18, 2022

Copy link
Copy Markdown

This pull request introduces 11 alerts when merging 0e1e251 into cf8a90f - view on LGTM.com

new alerts:

  • 11 for Missing variable declaration

@lgtm-com

lgtm-com Bot commented May 18, 2022

Copy link
Copy Markdown

This pull request introduces 11 alerts when merging e868f6a into cf8a90f - view on LGTM.com

new alerts:

  • 11 for Missing variable declaration

@haeter525 haeter525 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice feature!

@lgtm-com

lgtm-com Bot commented May 18, 2022

Copy link
Copy Markdown

This pull request introduces 11 alerts when merging de475c0 into cf8a90f - view on LGTM.com

new alerts:

  • 11 for Missing variable declaration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new feature to generate Quark web report

4 participants