Skip to content

[#444] Adjust CWE Show Case format in README.md.#445

Merged
sidra-asa merged 4 commits into
ev-flow:masterfrom
PoJenC:issue-#444
Jan 3, 2023
Merged

[#444] Adjust CWE Show Case format in README.md.#445
sidra-asa merged 4 commits into
ev-flow:masterfrom
PoJenC:issue-#444

Conversation

@PoJenC

@PoJenC PoJenC commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

CWE Showcases

  • CWE-020 Improper Input Validation
  • CWE-089 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')
  • CWE-094 Improper Control of Generation of Code ('Code Injection')
  • CWE-312 Cleartext Storage of Sensitive Information
  • CWE-319 Cleartext Transmission of Sensitive Information
  • CWE-327 Use of a Broken or Risky Cryptographic Algorithm
  • CWE-532 Insertion of Sensitive Information into Log File
  • CWE-749 Exposed Dangerous Method or Function
  • CWE-780 Use of RSA Algorithm without OAEP
  • CWE-798 Use of Hard-coded Credentials
  • CWE-921 Storage of Sensitive Data in a Mechanism without Access Control
  • CWE-926 Improper Export of Android Application Components

@sidra-asa sidra-asa self-assigned this Dec 30, 2022
@sidra-asa sidra-asa added pr-processing-state-04 work-in-progress The issue or pull request is currently work-in-progress labels Dec 30, 2022
@codecov-commenter

codecov-commenter commented Dec 30, 2022

Copy link
Copy Markdown

Codecov Report

Base: 78.52% // Head: 78.52% // No change to project coverage 👍

Coverage data is based on head (f3b7989) compared to base (ff96281).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files          63       63           
  Lines        4778     4778           
=======================================
  Hits         3752     3752           
  Misses       1026     1026           
Flag Coverage Δ
unittests 78.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sidra-asa

Copy link
Copy Markdown
Collaborator

@PoJenC

It looks like the new format is a list, not a table.
If the expected format is a table, please correct either the commits or description of this PR.

@sidra-asa

Copy link
Copy Markdown
Collaborator

@PoJenC

I also found that there are some issues in Codacy Static Code Analysis.
Please follow the suggestions in the details.

@sidra-asa

Copy link
Copy Markdown
Collaborator

@PoJenC

Could you also post a screenshot of revised CWE Show Case in the PR description ?

@sidra-asa sidra-asa requested a review from 18z December 30, 2022 15:03
@PoJenC

PoJenC commented Dec 30, 2022

Copy link
Copy Markdown
Contributor Author

@PoJenC

It looks like the new format is a list, not a table. If the expected format is a table, please correct either the commits or description of this PR.

@PoJenC PoJenC closed this Dec 30, 2022
@PoJenC PoJenC reopened this Dec 30, 2022
@PoJenC

PoJenC commented Dec 30, 2022

Copy link
Copy Markdown
Contributor Author

Hi @sidra-asa ,

  1. The space issue that Codacy indicated is fixed. Thanks.
  2. The list format of markdown is easier to maintain than the table format, and it's clearer for reading.

@sidra-asa sidra-asa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@18z Do you approve it?

@18z

18z commented Jan 3, 2023

Copy link
Copy Markdown
Member

LGTM, @18z approves this PR.

@sidra-asa sidra-asa merged commit 6105d62 into ev-flow:master Jan 3, 2023
@haeter525 haeter525 removed the work-in-progress The issue or pull request is currently work-in-progress label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants