Skip to content

Bugfix for issue #46#49

Merged
krnick merged 2 commits into
masterfrom
hotfix
Mar 20, 2020
Merged

Bugfix for issue #46#49
krnick merged 2 commits into
masterfrom
hotfix

Conversation

@krnick

@krnick krnick commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

No description provided.

krnick and others added 2 commits March 2, 2020 09:58
* Add visited_methods for preventing recursive problem

Co-authored-by: JunWei Song <sungboss2004@gmail.com>
@pep8speaks

Copy link
Copy Markdown

Hello @krnick! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 48:80: E501 line too long (99 > 79 characters)

@ghost

ghost commented Mar 20, 2020

Copy link
Copy Markdown

🤖 Thanks for the pull_request @krnick!
Your commit is on https://github.com/quark-engine/quark-engine/pull/49.diff
Full Url: https://github.com/krnick/quark-engine
Pull Request number is : 49
There is no TYPO found

I will look into it ASAP! (I'm a bot, BTW 🤖).

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #49 into master will increase coverage by 0.08%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   76.03%   76.11%   +0.08%     
==========================================
  Files          24       24              
  Lines         847      850       +3     
==========================================
+ Hits          644      647       +3     
  Misses        203      203              
Impacted Files Coverage Δ
quark/Objects/xrule.py 55.80% <80.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0e395...f9c33c0. Read the comment docs.

@krnick

krnick commented Mar 20, 2020

Copy link
Copy Markdown
Contributor Author

@krnick krnick merged commit d278368 into master Mar 20, 2020
@krnick krnick deleted the hotfix branch March 20, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants