Skip to content

Improve getParamValue API for More Accurate Parameter Extraction from Smali Code#666

Merged
haeter525 merged 4 commits into
ev-flow:masterfrom
pulorsok:master
Aug 2, 2024
Merged

Improve getParamValue API for More Accurate Parameter Extraction from Smali Code#666
haeter525 merged 4 commits into
ev-flow:masterfrom
pulorsok:master

Conversation

@pulorsok

@pulorsok pulorsok commented Aug 1, 2024

Copy link
Copy Markdown
Member

Description:
This pull request enhances the getParamValue API, which is responsible for extracting method parameters from smali code provided as strings. The primary focus of this update is to refine the filtering mechanism, ensuring cleaner and more accurate extraction of parameters without including extraneous characters.

Refer to issue #665.

@pep8speaks

pep8speaks commented Aug 1, 2024

Copy link
Copy Markdown

Hello @pulorsok! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-08-02 06:45:43 UTC

@codecov

codecov Bot commented Aug 1, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (5d2eda6) to head (2403b32).

Files Patch % Lines
quark/script/__init__.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   78.73%   78.81%   +0.07%     
==========================================
  Files          64       64              
  Lines        5324     5352      +28     
==========================================
+ Hits         4192     4218      +26     
- Misses       1132     1134       +2     
Flag Coverage Δ
unittests 78.81% <94.11%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haeter525 haeter525 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank @pulorsok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants