Update minimum python version to 3.9#680
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
+ Coverage 78.63% 78.65% +0.01%
==========================================
Files 71 71
Lines 5635 5635
==========================================
+ Hits 4431 4432 +1
+ Misses 1204 1203 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zinwang
added
dependencies
haeter525
requested changes
Sep 2, 2024
haeter525
left a comment
haeter525
left a comment
Member
There was a problem hiding this comment.
Thank @zinwang for this PR. Some suggestions below.
- Could you help fix the conflict in README?
- Please update the CI in quark-script so that it doesn't fail if we merge the PR.
…into update_minimum_python_to_39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to Issue #679