Skip to content

Replace importlib_resources with builtin module of Python#720

Merged
haeter525 merged 1 commit into
ev-flow:masterfrom
zinwang:replace_importlib_resources_with_builtin_module
Dec 2, 2024
Merged

Replace importlib_resources with builtin module of Python#720
haeter525 merged 1 commit into
ev-flow:masterfrom
zinwang:replace_importlib_resources_with_builtin_module

Conversation

@zinwang

@zinwang zinwang commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Refer to issue #718.

@zinwang zinwang added dependencies Pull requests that update a dependency file pr-processing-state-05 labels Dec 2, 2024
@zinwang zinwang self-assigned this Dec 2, 2024
@haeter525 haeter525 linked an issue Dec 2, 2024 that may be closed by this pull request
@codecov

codecov Bot commented Dec 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (65a2478) to head (f39aa34).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files          73       73           
  Lines        5732     5732           
=======================================
  Hits         4541     4541           
  Misses       1191     1191           
Flag Coverage Δ
unittests 79.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zinwang zinwang requested a review from haeter525 December 2, 2024 06:34

@haeter525 haeter525 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haeter525 haeter525 merged commit 1fbfc18 into ev-flow:master Dec 2, 2024
@zinwang zinwang deleted the replace_importlib_resources_with_builtin_module branch December 28, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError Due to Missing Dependency in setup.py

2 participants