Skip to content

Round the total score to an integer in the Quark report#773

Merged
zinwang merged 1 commit into
masterfrom
JerryTasi-patch-letTotalScoreBeInt
Jul 3, 2025
Merged

Round the total score to an integer in the Quark report#773
zinwang merged 1 commit into
masterfrom
JerryTasi-patch-letTotalScoreBeInt

Conversation

@JerryTasi

Copy link
Copy Markdown
Contributor

Refer to Issue #772

@zinwang zinwang self-requested a review July 3, 2025 02:30
@zinwang zinwang self-assigned this Jul 3, 2025

@zinwang zinwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov

codecov Bot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (cfee070) to head (47cd0b3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files          75       75           
  Lines        6265     6265           
=======================================
  Hits         5058     5058           
  Misses       1207     1207           
Flag Coverage Δ
unittests 80.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JerryTasi JerryTasi changed the title Apply rounding to total_score to let it be an integer in Quark report Round the total score to an integer in the Quark report Jul 3, 2025
@zinwang zinwang merged commit d173451 into master Jul 3, 2025
19 checks passed
@JerryTasi JerryTasi deleted the JerryTasi-patch-letTotalScoreBeInt branch July 30, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants