Skip to content

core.ButtonBase misses buttons_pressed definition #77

@EricPobot

Description

@EricPobot

The property is referenced in several methods of the ButtonBase class but it is defined in ButtonEVIO which is a subclass of it.

It works for now since the concrete classes seem to use ButtonEVIO (at list in the EV3 variant).

In ButtonBase, we should add something like:

@property
def buttons_pressed(self):
    return []

or better IMHO (since ButtonBase is supposed to be an abstract class):

@property
def buttons_pressed(self):
    raise NotImplementedError()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions