New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/RFC] Use Alien::Base to simplify the module #15

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@jamessan

jamessan commented Sep 29, 2015

  • Replace the unpacked sources with the tarball, which
    Alien::Base::ModuleBuild will automatically unpack
  • Use alien_helper to consolidate common variables used in build
    commands
  • Replace custom functions with use of
    alien_{build,test,install}_commands metadata
  • Determine Subversion version (and therefore the dist's version) from
    the unpacked sources.

There are still some rough edges (e.g. "./Build", "./Build clean", "./Build"
fails) which aren't clear to me whether it's an issue of how I'm using the tools
or the tools themselves.

However, I think this was a decent experiment and could make some things a bit
easier in the future.

  • Maintaining a delta against the upstream sources (as suggested in #12) could
    be handled using Alien::patch, as per Alien::Base::FAQ.
  • Automatically building the latest upstream release instead of committing
    a specific version. This is actually a trivial change to the alien_repository
    settings, except that 1.9.2 doesn't build out of the box (PERL_MM_OPTS conflict
    with hard-coded PREFIX in upstream Makefile).
Use Alien::Base to simplify the module
- Replace the unpacked sources with the tarball, which
  Alien::Base::ModuleBuild will automatically unpack
- Use alien_helper to consolidate common variables used in build
  commands
- Replace custom functions with use of
  alien_{build,test,install}_commands metadata
- Determine Subversion version (and therefore the dist's version) from
  the unpacked sources.

@jamessan jamessan closed this Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment