v2.9.1: several tests fail under Perl v5.12.3 #220

Closed
Lx opened this Issue Apr 22, 2012 · 7 comments

Comments

Projects
None yet
3 participants

Lx commented Apr 22, 2012

Some test failures occur due to an unexpected trailing period in some error messages. One is Unicode-related and I have very little understanding of what's happening there.

$ ./Build test
cc -I/home/lx/perl5/perlbrew/perls/perl-5.12.3/lib/5.12.3/x86_64-linux/CORE -fPIC -c -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -o bin/perl5i.o bin/perl5i.c
cc -fstack-protector -L/usr/local/lib -o bin/perl5i bin/perl5i.o
t/ARGV.t ..................... ok   
t/ARGV_twice.t ............... ok   
t/CLASS.t .................... ok   
t/Child.t .................... ok    
t/English.t .................. ok   
t/File-stat.t ................ ok   
t/List-MoreUtils/all.t ....... ok   
t/List-MoreUtils/any.t ....... ok   
t/List-MoreUtils/false.t ..... ok   
t/List-MoreUtils/mesh.t ...... ok   
t/List-MoreUtils/minmax.t .... ok   
t/List-MoreUtils/none.t ...... ok   
t/List-MoreUtils/true.t ...... ok   
t/List-MoreUtils/uniq.t ...... ok   
t/List-Util/first.t .......... ok     
t/List-Util/max.t ............ ok   
t/List-Util/maxstr.t ......... ok   
t/List-Util/min.t ............ ok   
t/List-Util/minstr.t ......... ok   
t/List-Util/reduce.t ......... ok     
t/List-Util/shuffle.t ........ ok   
t/List-Util/sum.t ............ ok   
t/Meta/ISA.t ................. ok   
t/Meta/checksum.t ............ ok    
t/Meta/class.t ............... ok   
t/Meta/id.t .................. ok    
t/Meta/is-equal.t ............ ok    
t/Meta/linear_isa.t .......... ok   
t/Meta/methods.t ............. ok    
t/Meta/reftype.t ............. ok   
t/Meta/super.t ............... 1/? 
#   Failed test at t/Meta/super.t line 77.
#          got: 'super() called outside a method at t/Meta/super.t line 76.
# '
#     expected: 'super() called outside a method at t/Meta/super.t line 76
# '

#   Failed test at t/Meta/super.t line 96.
#          got: '"NotAParent" is not a parent class of "Child" at t/Meta/super.t line 90.
# '
#     expected: '"NotAParent" is not a parent class of "Child" at t/Meta/super.t line 90
# '
# Looks like you failed 2 tests of 8.
t/Meta/super.t ............... Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/8 subtests 
t/Meta/symbol_table.t ........ ok   
t/Want.t ..................... ok   
t/alias.t .................... ok    
t/autobox.t .................. ok   
t/autodie.t .................. ok   
t/autovivification.t ......... ok   
t/caller.t ................... ok    
t/can.t ...................... ok   
t/capture.t .................. ok   
t/carp.t ..................... ok   
t/center.t ................... ok    
t/chdir.t .................... ok   
t/command_line_wrapper.t ..... ok    
t/commify.t .................. ok    
t/datetime.t ................. ok    
t/die.t ...................... ok    
t/diff.t ..................... ok    
t/dump/array.t ............... ok   
t/dump/code.t ................ ok   
t/dump/hash.t ................ ok   
t/dump/obj.t ................. ok   
t/dump/scalar.t .............. ok   
t/each.t ..................... ok   
t/equal.t .................... ok     
t/everything_is_an_object.t .. ok   
t/flip.t ..................... ok   
t/foreach.t .................. 1/? 
#   Failed test at t/foreach.t line 55.
#          got: 'Function passed to foreach takes no arguments at t/foreach.t line 54.
# '
#     expected: 'Function passed to foreach takes no arguments at t/foreach.t line 54
# '
# Looks like you failed 1 test of 6.
t/foreach.t .................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/6 subtests 
t/github164.t ................ ok   
t/grep.t ..................... ok    
t/hash-diff.t ................ ok   
t/hash-intersect.t ........... ok   
t/hash-merge.t ............... ok   
t/intersect.t ................ ok    
t/io-handle.t ................ ok   
t/is_module_name.t ........... ok    
t/lexical.t .................. ok   
t/list-trim.t ................ ok    
t/list.t ..................... ok   
t/load_together.t ............ ok   
t/map.t ...................... ok   
t/method_leaking.t ........... ok   
t/modern_perl.t .............. ok   
t/module2path.t .............. ok    
t/no_indirect.t .............. ok   
t/number.t ................... ok    
t/perl5i.t ................... ok   
t/require.t .................. ok    
t/require_message.t .......... ok   
t/say.t ...................... ok   
t/scalar.t ................... ok    
t/signature.t ................ ok    
t/signatures.t ............... ok    
t/taint.t .................... ok    
t/time_compat.t .............. ok    
t/true.t ..................... ok   
t/try-tiny.t ................. ok   
t/uniq.t ..................... ok   
t/utf8.t ..................... 1/? 
#   Failed test at t/utf8.t line 23.
# {
#   'GLOB(0x2490fc8)' => [
#     'unix',
#     'perlio'
#   ]
# }
# Looks like you failed 1 test of 8.
t/utf8.t ..................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests 
t/version_0/00_compile.t ..... skipped: Needs Time::y2038
t/version_1/00_compile.t ..... skipped: Needs Time::y2038
t/vs_listmoreutils.t ......... ok   
t/wrap.t ..................... ok    
t/y2038.t .................... ok   

Test Summary Report
-------------------
t/Meta/super.t             (Wstat: 512 Tests: 8 Failed: 2)
  Failed tests:  6, 8
  Non-zero exit status: 2
t/foreach.t                (Wstat: 256 Tests: 6 Failed: 1)
  Failed test:  6
  Non-zero exit status: 1
t/utf8.t                   (Wstat: 256 Tests: 8 Failed: 1)
  Failed test:  6
  Non-zero exit status: 1
Files=94, Tests=1094, 35 wallclock secs ( 0.42 usr  0.29 sys + 24.37 cusr  2.76 csys = 27.84 CPU)
Result: FAIL
Failed 3/94 test programs. 4/1094 subtests failed.

$ perl -V
Summary of my perl5 (revision 5 version 12 subversion 3) configuration:

  Platform:
    osname=linux, osvers=2.6.35-28-generic, archname=x86_64-linux
    uname='linux pluto 2.6.35-28-generic #49-ubuntu smp tue mar 1 14:39:03 utc 2011 x86_64 gnulinux '
    config_args='-de -Dprefix=/home/lx/perl5/perlbrew/perls/perl-5.12.3'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.4.5', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib /lib64 /usr/lib64
    libs=-lnsl -ldl -lm -lcrypt -lutil -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
    libc=/lib/libc-2.12.1.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.12.1'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'


Characteristics of this binary (from libperl): 
  Compile-time options: PERL_DONT_CREATE_GVSV PERL_MALLOC_WRAP USE_64_BIT_ALL
                        USE_64_BIT_INT USE_LARGE_FILES USE_PERLIO
                        USE_PERL_ATOF
  Built under linux
  Compiled at Mar 24 2011 16:07:42
  %ENV:
    PERLBREW_PATH="/home/lx/perl5/perlbrew/bin:/home/lx/perl5/perlbrew/perls/current/bin"
    PERLBREW_PERL="perl-5.12.3"
    PERLBREW_ROOT="/home/lx/perl5/perlbrew"
    PERLBREW_VERSION="0.18"
  @INC:
    /home/lx/perl5/perlbrew/perls/perl-5.12.3/lib/site_perl/5.12.3/x86_64-linux
    /home/lx/perl5/perlbrew/perls/perl-5.12.3/lib/site_perl/5.12.3
    /home/lx/perl5/perlbrew/perls/perl-5.12.3/lib/5.12.3/x86_64-linux
    /home/lx/perl5/perlbrew/perls/perl-5.12.3/lib/5.12.3
    .
Contributor

schwern commented Apr 22, 2012

Thanks for the report.

The trailing period is a new "feature" of Carp. I think you'll find you have
1.25 or similar. The tests will have to be adjusted.

The Unicode failures are puzzling. What version of utf8::all do you have please?

Lx commented Apr 22, 2012

I have Carp 1.25 and utf8::all 0.004.

@doherty doherty added a commit to doherty/perl5i that referenced this issue May 12, 2012

@doherty doherty Ignore the period in tested warnings
New perls have a period at the end of this warning - now we match
the warning without regard for the period.

Fixes #220
0e79e09
Contributor

schwern commented Jun 18, 2012

829827e fixes the Carp issue across the board (sorry, @doherty, I didn't see your fix) and #223 will fix the utf8 issues.

I just ran into the exact same failures in perl 5.14.2 with Carp 1.25 and utf8:all 0.004.
Nice to see there is a fix pending, will have to try it out.

Confirmed #223 fixes these issues for me

Contributor

schwern commented Jun 19, 2012

@spacebat Thanks for the feedback.

Contributor

schwern commented Jul 7, 2012

That should do it, everything should be working next release coming Real Soon Now™

schwern closed this Jul 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment