From be4b60dc66e637091b09e00c26041819d363f3b9 Mon Sep 17 00:00:00 2001
From: Jonathan Haas <jonathan@haas.holdings>
Date: Sat, 9 May 2026 23:28:56 -0700
Subject: [PATCH] ci: skip feedback artifacts after preflight failure

---
 .github/workflows/review-feedback-backfill.yml | 5 +++--
 .github/workflows/review-feedback-sentinel.yml | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/review-feedback-backfill.yml b/.github/workflows/review-feedback-backfill.yml
index dbbc4f7..6fe2d16 100644
--- a/.github/workflows/review-feedback-backfill.yml
+++ b/.github/workflows/review-feedback-backfill.yml
@@ -43,6 +43,7 @@ jobs:
           fi
 
       - name: Run review feedback backfill
+        id: backfill
         run: |
           set +e
           ruby .github/scripts/sweep-recent-review-feedback.rb \
@@ -72,7 +73,7 @@ jobs:
           exit "${status}"
 
       - name: Upload review feedback 30-day ledger
-        if: always()
+        if: ${{ always() && steps.backfill.outcome != 'skipped' }}
         uses: actions/upload-artifact@v4
         with:
           name: review-feedback-30d-ledger
@@ -83,7 +84,7 @@ jobs:
           retention-days: 90
 
       - name: Upload review feedback 30-day guardrail backlog
-        if: always()
+        if: ${{ always() && steps.backfill.outcome != 'skipped' }}
         uses: actions/upload-artifact@v4
         with:
           name: review-feedback-30d-guardrail-backlog
diff --git a/.github/workflows/review-feedback-sentinel.yml b/.github/workflows/review-feedback-sentinel.yml
index 54306ea..83de825 100644
--- a/.github/workflows/review-feedback-sentinel.yml
+++ b/.github/workflows/review-feedback-sentinel.yml
@@ -43,6 +43,7 @@ jobs:
           fi
 
       - name: Sweep recent merged PR feedback
+        id: sweep
         run: |
           set +e
           ruby .github/scripts/sweep-recent-review-feedback.rb \
@@ -74,7 +75,7 @@ jobs:
           exit "${status}"
 
       - name: Upload review feedback ledger
-        if: always()
+        if: ${{ always() && steps.sweep.outcome != 'skipped' }}
         uses: actions/upload-artifact@v4
         with:
           name: review-feedback-ledger
@@ -83,7 +84,7 @@ jobs:
           retention-days: 30
 
       - name: Upload review feedback guardrail backlog
-        if: always()
+        if: ${{ always() && steps.sweep.outcome != 'skipped' }}
         uses: actions/upload-artifact@v4
         with:
           name: review-feedback-guardrail-backlog