Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the bug fix for the AMXX 182 menu filling on AMXX 183 #72

Closed
evandrocoan opened this issue Jul 12, 2017 · 3 comments
Closed

Remove the bug fix for the AMXX 182 menu filling on AMXX 183 #72

evandrocoan opened this issue Jul 12, 2017 · 3 comments

Comments

@evandrocoan
Copy link
Owner

image

It is a bug fix for the AMXX 182 menu filling:
[QUOTE='https://www.amxmodx.org/api/newmenus/menu_addblank']
When using slot=1 this might break your menu.
[/QUOTE]
So I added the OFF text as filler and be able to put the back and next buttons at the bottom of the page.

https://forums.alliedmods.net/showthread.php?p=2534749#post2534749

[QUOTE=BeNq!;2534826]I have AMXX 1.8.3-re.[/QUOTE]

I only implemented it for AMXX 182, so if you use AMXX 183, it will also be like that.
So, I can look into adding better support for AMXX 183, removing this workaround/kludge.

@fred0r
Copy link

fred0r commented Nov 16, 2017

Are you planning a fix ?

@evandrocoan
Copy link
Owner Author

evandrocoan commented Nov 17, 2017

I am not sure anymore, I am not playing for now or a long time. But how much urgent is this?

evandrocoan added a commit that referenced this issue Aug 17, 2018
evandrocoan pushed a commit that referenced this issue Dec 3, 2018
Tested and works on dedicated server under build 1.8.3-dev 5177.
evandrocoan added a commit that referenced this issue Dec 3, 2018
@fred0r
Copy link

fred0r commented Dec 28, 2018

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants