New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chained promises are not included when using $q.tick() #6

Closed
evangalen opened this Issue Dec 1, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@evangalen
Owner

evangalen commented Dec 1, 2014

The $q.tick() should support support (internal $q) "nextTick" registration done while executing an earlier registered "nextTick" callback; this to support chained promises (i.e. .then(function() { /* ... */)..then(function() { /* ... */)).

NOTE: a $rootScope.$digest() internally keeps on digesting using no further change is detection (in the case of $q until no further $evalAsync's are registered from a "nextTick" callback).
But this looping behavior wasn't originally in the 0.2.1 / 0.2.0 really of ngImprovedTesting causing chained promises to not work as expected.

@evangalen evangalen added the bug label Dec 1, 2014

@evangalen evangalen added this to the 0.2.2 milestone Dec 1, 2014

@evangalen evangalen self-assigned this Dec 1, 2014

@evangalen evangalen closed this in e1745d3 Dec 1, 2014

@evangalen evangalen changed the title from Chained promises are not resolved when using $q.tick() to Chained promises are not included when using $q.tick() Dec 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment