Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Output chains are mangled when SSI module is not included in nginx #17

Open
anthonyryan1 opened this Issue · 6 comments

4 participants

@anthonyryan1

I have encountered a bug where mod_zip delivers the raw content, then the HTTP headers, then the zip file header, in that order, producing an invalid zip file.

I would like to request additional instruction for how to debug this further and produce a helpful bug report.

@Optix

Having the same issue yesterday and i've resolved it : don't remove any nginx module during compilation process (eg --without...). I have compiled the v1,4.2 with just adding mod_zip, it works :)

@loe

Just to +1 @Optix comment, recompiling without removing any modules fixes the issue.

@anthonyryan1

I have finally had the time to verify this more carefully and determined that it is --without-http_ssi_module that breaks this module, no other exclusions seem to affect it from what I've tested. Has anyone else observed any others that independently break it?

@anthonyryan1

My leading thought for the explanation of this is that it has something to do with nginx's buffering, but I'm at a loss for explaining it, given it occurs with ssi disabled but not gzip.

In the interest of understanding this issue better and improving the reliability of this module, I'm offering a $500 bug bounty to the individual who explains and fixes this bug.

To claim this you must:

  • Explain what causes this to occur, and how it relates to the ssi module.
  • Write a sustainable patch to fix it that is acceptable to the package maintainer.
  • Have a Paypal account to receive the bounty.

I'm going to leave this offer open until December 31, 2014.

@ccverg

@anthonyryan1 have you heard of Bountysource? You can put a bounty directly on this issue here: https://www.bountysource.com/issues/979501

@anthonyryan1

It looks like this isn't the only nginx module affected by this issue: https://github.com/openresty/echo-nginx-module/blob/master/README.markdown#known-issues

@anthonyryan1 anthonyryan1 changed the title from HTTP headers sent after content to Output changes are mangled when SSI module is not included in nginx
@anthonyryan1 anthonyryan1 referenced this issue from a commit in anthonyryan1/mod_zip
@anthonyryan1 anthonyryan1 Explicitly depend upon the http_postpone_filter_module
Previously mod_zip would mangle the output chain if another module
did not happen to require the postpone_filter module. By making this
dependency explicit we can avoid a bug when nginx is compiled with
certain configuration options.

Fixes #17
dce8f28
@anthonyryan1 anthonyryan1 changed the title from Output changes are mangled when SSI module is not included in nginx to Output chains are mangled when SSI module is not included in nginx
@anthonyryan1 anthonyryan1 referenced this issue from a commit in anthonyryan1/mod_zip
@anthonyryan1 anthonyryan1 Explicitly depend upon the http_postpone_filter_module
Previously mod_zip would mangle the output chain if another module
did not happen to require the postpone_filter module. By making this
dependency explicit we can avoid a bug when nginx is compiled with
certain configuration options.

Fixes #17
2995354
@anthonyryan1 anthonyryan1 referenced this issue from a commit in anthonyryan1/mod_zip
@anthonyryan1 anthonyryan1 Explicitly depend upon the http_postpone_filter_module
Previously mod_zip would mangle the output chain if another module
did not happen to require the postpone_filter module. By making this
dependency explicit we can avoid a bug when nginx is compiled with
certain configuration options.

Fixes #17
e5df6f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.