add nil-pointer checks to avoid runtime panics #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

evanphx merged 1 commit into evanphx:master from clagraff:master

Mar 16, 2018

Contributor

clagraff commented Mar 16, 2018

Addresses the nil-pointer issue of tryDoc and tryAry.
Inspired by schylek's PR #49 .

Also adds a couple extra nil-pointer checks for lazyNode.

However, because how everything is currently coded, I don't see an avenue for intoDoc(), intoAry(), or compact() to actually have nil pointers to the n.raw property. So this was mostly "future-proofing" in case this ever changes. I can remove these extra checks or change the error messages if you would like 👍.

Doesn't modify the license.


          add nil-pointer checks to avoid runtime panics

975445d

Signed-off-by: Curtis La Graff <curtis@lagraff.me>

Owner

evanphx commented Mar 16, 2018

I thank you and @schylek thanks you.

evanphx merged commit ed7cfba into evanphx:master

evanphx mentioned this pull request

Fix for testing objects/arrays against null. #49

Closed

schylek added a commit to schylek/kubernetes that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

758d3e7

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

schylek mentioned this pull request

vendor: Update github.com/evanphx/json-patch kubernetes/kubernetes#61354

Merged

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request


          Merge pull request #61354 from schylek/master

18a7ea7

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

k8s-publishing-bot pushed a commit to kubernetes/apimachinery that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

fcb9a12

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

k8s-publishing-bot added a commit to kubernetes/apimachinery that referenced this pull request


          Merge pull request #61354 from schylek/master

b94e5e6

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

k8s-publishing-bot pushed a commit to kubernetes/apiserver that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

291f8ff

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

k8s-publishing-bot added a commit to kubernetes/apiserver that referenced this pull request


          Merge pull request #61354 from schylek/master

bd91987

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

k8s-publishing-bot pushed a commit to kubernetes/kube-aggregator that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

a7f12ca

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

k8s-publishing-bot added a commit to kubernetes/kube-aggregator that referenced this pull request


          Merge pull request #61354 from schylek/master

bcde76f

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

k8s-publishing-bot pushed a commit to kubernetes/sample-apiserver that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

k8s-publishing-bot added a commit to kubernetes/sample-apiserver that referenced this pull request


          Merge pull request #61354 from schylek/master

5953b96

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

k8s-publishing-bot pushed a commit to kubernetes/apiextensions-apiserver that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

32cb379

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

k8s-publishing-bot added a commit to kubernetes/apiextensions-apiserver that referenced this pull request


          Merge pull request #61354 from schylek/master

9fadc6b

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

sttts pushed a commit to sttts/apimachinery that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

500355e

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

sttts pushed a commit to sttts/apimachinery that referenced this pull request


          Merge pull request #61354 from schylek/master

4b5b41c

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

sttts pushed a commit to sttts/apiserver that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

da77b14

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

sttts pushed a commit to sttts/apiserver that referenced this pull request


          Merge pull request #61354 from schylek/master

93b6202

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

sttts pushed a commit to sttts/kube-aggregator that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

b80ba8a

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

sttts pushed a commit to sttts/kube-aggregator that referenced this pull request


          Merge pull request #61354 from schylek/master

3b5ed96

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

sttts pushed a commit to sttts/sample-apiserver that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

baabee2

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

sttts pushed a commit to sttts/sample-apiserver that referenced this pull request


          Merge pull request #61354 from schylek/master

f7f2349

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

sttts pushed a commit to sttts/apiextensions-apiserver that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

3a8547f

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

sttts pushed a commit to sttts/apiextensions-apiserver that referenced this pull request


          Merge pull request #61354 from schylek/master

98dc1b2

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

openshift-publish-robot pushed a commit to openshift/kubernetes-sample-apiserver that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

3b088bb

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

openshift-publish-robot pushed a commit to openshift/kubernetes-sample-apiserver that referenced this pull request


          Merge pull request #61354 from schylek/master

22ffc21

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

tamalsaha pushed a commit to gomodules/encoding that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

2df628e

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

tamalsaha pushed a commit to gomodules/encoding that referenced this pull request


          Merge pull request #61354 from schylek/master

b047990

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

akhilerm pushed a commit to akhilerm/apimachinery that referenced this pull request


          vendor: Update github.com/evanphx/json-patch

a290570

Updates github.com/evanphx/json-patch dependency
to fix tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 758d3e7c576f0761b23fed69c3b5dabf6013e8d0

akhilerm pushed a commit to akhilerm/apimachinery that referenced this pull request


          Merge pull request #61354 from schylek/master

b470637

Automatic merge from submit-queue (batch tested with PRs 61354, 61366, 61386, 61394, 60755). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

vendor: Update github.com/evanphx/json-patch

Updates github.com/evanphx/json-patch dependency
to fix handling tests against empty objects/arrays.

Includes fix from evanphx/json-patch#50

Kubernetes-commit: 18a7ea703bdf09f1ff0b83e15b3febf49a447a24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet