New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pacific/Auckland #55

Closed
ndw opened this Issue Nov 20, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@ndw

ndw commented Nov 20, 2018

The bounding box for Pacific/Auckland seems to be incorrect:

-29.03033,-179.059153
-29.03033,179.364359
-52.821369,179.364359
-52.821369,-179.059153
-29.03033,-179.059153
@evansiroky

This comment has been minimized.

Owner

evansiroky commented Nov 20, 2018

This is due to Raoul Island being included as part of New Zealand and Pacific/Auckland. The Time in New Zealand Wikipedia article doesn't include any indication that would suggest that Raoul Island uses a different timezone than the mainland, so I think it is correct to keep these islands as a part of Pacific/Auckland.

@evansiroky evansiroky closed this Nov 20, 2018

@ndw

This comment has been minimized.

ndw commented Nov 20, 2018

Ok. Perhaps I misunderstand something about the shapefile format. I'll stop bothering you.

I thought the bounding box was meant to cover the entire region governed by the timezone. New Zealand extends from -179 to at least -194 so the bounding box I extracted looks much too small.

@evansiroky

This comment has been minimized.

Owner

evansiroky commented Nov 20, 2018

You're not a bother at all! I very much appreciate people double checking the work here.

New Zealand is tricky for making bounding boxes in the WGS projection because it has some parts to the left and right of the 180th meridian. Therefore the bounding box appears to suggest that it stretches across almost the entire southern hemisphere.

@ndw

This comment has been minimized.

ndw commented Nov 20, 2018

Ah. That makes sense. That probably also explains the weird Leaflet behavior I'm seeing with polygons in New Zealand.

BTW, in case your curious, I'm using your map data and the IANA timezone files to drive the app at https://tzmap.nwalsh.com/ which, in turn, is just an example app demonstrating the underlying XQuery libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment