Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

fixed phantom connections

  • Loading branch information...
commit 9d7e0801245e93b62f29d956aae0ce12d6d16147 1 parent d6c0959
@evanw authored
Showing with 15 additions and 8 deletions.
  1. +2 −1  README.md
  2. +12 −7 TODO
  3. +1 −0  html/script.js
View
3  README.md
@@ -8,4 +8,5 @@ An IDE for [ROS](http://ros.org/) that runs in the web browser and edits the gra
## Notes
* RIDE unfortunately can't use the official [rosbridge](http://www.ros.org/wiki/rosbridge) package because that one drops messages by design, and RIDE assumes the messages it sends won't be dropped. RIDE includes a modified rosbridge node that can be configured to not drop messages.
-* This is not secure! ROS is a complex system and there is a high probability of remote code execution. Do not attempt to make RIDE available over the Internet.
+* Disconnecting and reconnecting currently results in duplicate messages because rosbridge doesn't unregister subscribers on disconnection.
+* This is not secure! ROS is a complex system and there is a high probability of arbitrary remote code execution. Do not attempt to make RIDE available over the Internet.
View
19 TODO
@@ -1,16 +1,21 @@
-- rosbridge bugs?
- - rosbridge drops messages and there's no way to tell it to be reliable
- this is fixed temporarily in ridebridge but needs an official fix
- - need to unsubscribe dropped connections from everything they subscribed to
- otherwise connecting multiple times means lots of copies of each message?
-- may need to have a way to rosmake a package
+TODO
+- minimap for large programs
+- automatic graph layout
+
+MAYBE
- show types of topics?
- do topics even have a single type?
- if so, maybe only show types along edges?
+- have a way to rosmake a package
- how to kill image_view when you close the window? what's going on?
-- minimap for large programs
DONE
+- fix bug with phantom connection when deleting a node
+- rosbridge bugs?
+ - rosbridge drops messages and there's no way to tell it to be reliable
+ this is fixed temporarily in ridebridge but needs an official fix
+ - need to unsubscribe dropped connections from everything they subscribed to
+ otherwise connecting multiple times means lots of copies of each message?
- get rid of temporary roslaunch files and run binaries directly?
- would get less cluttered stdout and exit code
- need better status information
View
1  html/script.js
@@ -129,6 +129,7 @@ var ride = {
// Remove the slot if it exists
if (slot) {
+ slot.targets.map(function(target) { slot.disconnect(target); });
slots.splice(slots.indexOf(slot), 1);
node.updateHTML();
this.graph.updateBounds();
Please sign in to comment.
Something went wrong with that request. Please try again.