New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Error when JSXSpreadAttribute is passed to isSemanticRoleElement #545

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@jessebeach
Copy link
Collaborator

jessebeach commented Feb 3, 2019

This was an error I ran into when running v6.2.0 on the FB codebase. It took me a while to get the test case, but now that I have it, I put up the fix.

I included the CHANGELOG patch bump in this PR so that I can npm version patch it right after.

Fixes #536

@jessebeach jessebeach requested review from evcohen , lencioni and ljharb Feb 3, 2019

@jessebeach jessebeach force-pushed the fix--isSemanticRoleElement branch from 9980e45 to 610eef7 Feb 3, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 610eef7 on fix--isSemanticRoleElement into 33a7d69 on master.

6 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 610eef7 on fix--isSemanticRoleElement into 33a7d69 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 610eef7 on fix--isSemanticRoleElement into 33a7d69 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 610eef7 on fix--isSemanticRoleElement into 33a7d69 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 610eef7 on fix--isSemanticRoleElement into 33a7d69 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 610eef7 on fix--isSemanticRoleElement into 33a7d69 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 610eef7 on fix--isSemanticRoleElement into 33a7d69 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage increased (+0.09%) to 99.548% when pulling 4f79558 on fix--isSemanticRoleElement into 33a7d69 on master.

@ljharb

ljharb approved these changes Feb 3, 2019

Show resolved Hide resolved CHANGELOG.md Outdated

@jessebeach jessebeach force-pushed the fix--isSemanticRoleElement branch from 610eef7 to 4f79558 Feb 3, 2019

@jessebeach jessebeach merged commit db0aa24 into master Feb 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 99.548%
Details

@jessebeach jessebeach deleted the fix--isSemanticRoleElement branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment