New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removes deprecated rule label-has-for #546

Merged
merged 2 commits into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@hozefaj
Copy link
Contributor

hozefaj commented Feb 3, 2019

fixes #514

Have removed the label-has-for from the docs. not sure if it needs to be there with some kind of indication that it's deprecated?

@ljharb
Copy link
Collaborator

ljharb left a comment

Please rebase out the commit that's in #544.

@ljharb ljharb added the documentation label Feb 3, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage remained the same at 99.457% when pulling 0611b29 on hozefaj:remove-label-has-for into 33a7d69 on evcohen:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage remained the same at 99.457% when pulling 0611b29 on hozefaj:remove-label-has-for into 33a7d69 on evcohen:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage remained the same at 99.457% when pulling 155f79e on hozefaj:remove-label-has-for into 33a7d69 on evcohen:master.

@hozefaj

This comment has been minimized.

Copy link
Contributor Author

hozefaj commented Feb 3, 2019

Please rebase out the commit that's in #544.

Won't you need to first merge #544 for me to rebase the commit out?

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Feb 3, 2019

You should be able to just remove it from this PR, unless there's an overlap.

@hozefaj hozefaj force-pushed the hozefaj:remove-label-has-for branch from 0611b29 to 155f79e Feb 3, 2019

@hozefaj

This comment has been minimized.

Copy link
Contributor Author

hozefaj commented Feb 3, 2019

You should be able to just remove it from this PR, unless there's an overlap.

done

@ljharb

ljharb approved these changes Feb 3, 2019

@evcohen evcohen merged commit 220e9f4 into evcohen:master Feb 3, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment