Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #669: use the `language-tags` package to check the `lang` rule #670

Open
wants to merge 1 commit into
base: master
from

Conversation

@imtsuki
Copy link

imtsuki commented Mar 13, 2020

The language-tags package provides language tag validation functionality based on the latest IANA language subtag registry.

Instead of manually parsing tags like before, this PR makes use of this package and makes the lang rule more exhaustive and more robust. File src/util/attributes/ISO.json is removed then.

Signed-off-by: imtsuki me@qjx.app

The `language-tags` package provides language tag validation
functionality based on the latest IANA language subtag registry.

This PR makes use of this package instead of manually parsing tags
like before. File `src/util/attributes/ISO.json` is removed then.

Signed-off-by: imtsuki <me@qjx.app>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2020

Coverage Status

Coverage decreased (-0.001%) to 99.483% when pulling 42a2016 on imtsuki:fix-lang-rule into 7bcea20 on evcohen:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2020

Coverage Status

Coverage decreased (-0.001%) to 99.483% when pulling 42a2016 on imtsuki:fix-lang-rule into 7bcea20 on evcohen:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2020

Coverage Status

Coverage decreased (-0.001%) to 99.483% when pulling 42a2016 on imtsuki:fix-lang-rule into 7bcea20 on evcohen:master.

@ljharb
ljharb approved these changes Mar 13, 2020
Copy link
Collaborator

ljharb left a comment

Thanks, this looks great to me

@ljharb ljharb requested a review from jessebeach Mar 13, 2020
@ljharb ljharb added the enhancement label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.