Edmund von der Burg evdb

Organizations

@OpenBookPrices
@evdb

Thanks for spotting that - fixed in country-data@0.0.19 which is on npm now :)

@evdb

Thanks for spotting that - fixed in country-data@0.0.19 which is on npm now :)

@evdb
@evdb
Mexico Country Calling Codes
@evdb
Malaysia has only english in languages
@evdb

I'm starting to think that this is probably something that is outside the scope of the country-data module but that is obviously closely linked to …

@evdb

It is in countries.csv line 252, but the name it has in "Viet Nam" (as per the ISO3661 entry on wikipedia). Perhaps this is supporting evidence for…

@evdb

The need for a name_aka field of some sort is clear. However I wonder if what you're suggesting could also be used to provide the country name in o…

@evdb

Most of the data could be considered "facts" and as such not individually copyrightable. For example telephone numbers etc. The stuff that the copy…

@evdb
work-in-progress
@evdb

The folder is just there for reference - the data is not actually exposed via the module. I like to keep bad data around in this way so that they c…

@evdb

I'd be wary of adding the data directly as I think it would be hard to maintain. Also it seems that node-phone already has most of it. However it w…

evdb commented on pull request OpenBookPrices/country-data#23
@evdb

v0.0.18 went out on npm a few minutes after the tests passed on travis :) https://www.npmjs.com/package/country-data

@evdb

At the moment those calling codes are just in that file, not actually in the data that the module exposes. As such surely it is fine to leave it as…

@evdb
evdb commented on pull request OpenBookPrices/country-data#23
@evdb

Made a few little changes and have merged. Once tests have run on travis I'll bump the version and publish. Thanks for the contribution :)

evdb merged pull request OpenBookPrices/country-data#23
@evdb
data cleansed, tests added, continents added
14 commits with 858 additions and 710 deletions
@evdb
@evdb
regions.js is missing North America
evdb deleted branch iancrowther-master at OpenBookPrices/country-data
@evdb

The calling codes came originally from http://en.wikipedia.org/wiki/List_of_country_calling_codes. I'm not sure what a region code would be either,…

evdb commented on pull request OpenBookPrices/country-data#22
@evdb

The tests would be great - always keen to have tests :) Not sure which of Australasia or Oceania are better. It seems that the exact definitions ar…

evdb commented on pull request OpenBookPrices/country-data#22
@evdb

This all looks good - bar a few comments that I've made inline. Main concern is the regions.australia which I think should be regions.australasia b…

evdb commented on pull request OpenBookPrices/country-data#22
@evdb

Accidentally added header line :)

evdb commented on pull request OpenBookPrices/country-data#22
@evdb

would need changing as per note above

evdb commented on pull request OpenBookPrices/country-data#22
@evdb

Should this be regions.australasia as suggested by http://en.wikipedia.org/wiki/Australasia? In which case New Guinea should be included somehow...

@evdb
  • @evdb 03cf57e
    Change column order back to what is currently being used (which is no…